[GitHub] [iceberg] kbendick commented on a change in pull request #3472: Checkstyle: remove use of Parquet Preconditions and Apache Commons IOUtils

[GitBox <gi...@apache.org>]

kbendick commented on a change in pull request #3472:
URL: https://github.com/apache/iceberg/pull/3472#discussion_r743309931



##########
File path: .baseline/checkstyle/checkstyle.xml
##########
@@ -361,6 +366,10 @@
             <property name="format" value="\bIOUtils\.toString\("/>
             <property name="message" value="Prefer Guava''s [CharStreams,Files,Resources].toString to avoid charset/stream closing issues."/>
         </module>
+        <module name="RegexpSinglelineJava">
+            <property name="format" value="\bIOUtils\.copy\("/>
+            <property name="message" value="Prefer Guava''s ByteStreams.copy to avoid charset/stream closing issues."/>

Review comment:
       👍 . Thanks for adding this rule and the nice explanation.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org