You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2023/01/09 08:47:00 UTC
[GitHub] [shenyu] tian-pengfei opened a new pull request, #4304: [ISSUE #4208] Refactored Sign-plugin
tian-pengfei opened a new pull request, #4304:
URL: https://github.com/apache/shenyu/pull/4304
<!-- Describe your PR here; eg. Fixes #issueNo -->
<!--
Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
-->
Make sure that:
- [x] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
- [x] You submit test cases (unit or integration tests) that back your changes.
- [x] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] codecov-commenter commented on pull request #4304: [ISSUE #4208] Refactored Sign-plugin
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #4304:
URL: https://github.com/apache/shenyu/pull/4304#issuecomment-1375300750
# [Codecov](https://codecov.io/gh/apache/shenyu/pull/4304?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#4304](https://codecov.io/gh/apache/shenyu/pull/4304?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2245ab7) into [master](https://codecov.io/gh/apache/shenyu/commit/01988f4f039ec945eb1e4e9d2837e21be3e394be?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (01988f4) will **decrease** coverage by `0.06%`.
> The diff coverage is `95.57%`.
```diff
@@ Coverage Diff @@
## master #4304 +/- ##
============================================
- Coverage 67.86% 67.80% -0.07%
- Complexity 7392 7414 +22
============================================
Files 1013 1015 +2
Lines 28704 28733 +29
Branches 2572 2569 -3
============================================
+ Hits 19481 19483 +2
- Misses 7717 7743 +26
- Partials 1506 1507 +1
```
| [Impacted Files](https://codecov.io/gh/apache/shenyu/pull/4304?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nyu/plugin/global/DefaultShenyuContextBuilder.java](https://codecov.io/gh/apache/shenyu/pull/4304?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdsb2JhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9nbG9iYWwvRGVmYXVsdFNoZW55dUNvbnRleHRCdWlsZGVyLmphdmE=) | `79.16% <ø> (-4.17%)` | :arrow_down: |
| [...java/org/apache/shenyu/plugin/sign/SignPlugin.java](https://codecov.io/gh/apache/shenyu/pull/4304?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9TaWduUGx1Z2luLmphdmE=) | `87.50% <66.66%> (+2.31%)` | :arrow_up: |
| [...che/shenyu/plugin/sign/extractor/NewExtractor.java](https://codecov.io/gh/apache/shenyu/pull/4304?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9leHRyYWN0b3IvTmV3RXh0cmFjdG9yLmphdmE=) | `93.33% <93.33%> (ø)` | |
| [...nyu/plugin/sign/service/ComposableSignService.java](https://codecov.io/gh/apache/shenyu/pull/4304?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9zZXJ2aWNlL0NvbXBvc2FibGVTaWduU2VydmljZS5qYXZh) | `92.64% <94.44%> (ø)` | |
| [.../apache/shenyu/plugin/sign/api/SignParameters.java](https://codecov.io/gh/apache/shenyu/pull/4304?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9hcGkvU2lnblBhcmFtZXRlcnMuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...shenyu/plugin/sign/extractor/DefaultExtractor.java](https://codecov.io/gh/apache/shenyu/pull/4304?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9leHRyYWN0b3IvRGVmYXVsdEV4dHJhY3Rvci5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...enyu/plugin/sign/provider/DefaultSignProvider.java](https://codecov.io/gh/apache/shenyu/pull/4304?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9wcm92aWRlci9EZWZhdWx0U2lnblByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...e/shenyu/plugin/sign/provider/NewSignProvider.java](https://codecov.io/gh/apache/shenyu/pull/4304?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9wcm92aWRlci9OZXdTaWduUHJvdmlkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...t/starter/plugin/sign/SignPluginConfiguration.java](https://codecov.io/gh/apache/shenyu/pull/4304?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXIvc2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXItcGx1Z2luL3NoZW55dS1zcHJpbmctYm9vdC1zdGFydGVyLXBsdWdpbi1zaWduL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3ByaW5nYm9vdC9zdGFydGVyL3BsdWdpbi9zaWduL1NpZ25QbHVnaW5Db25maWd1cmF0aW9uLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java](https://codecov.io/gh/apache/shenyu/pull/4304?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9jYWNoZS9HcnBjQ2xpZW50Q2FjaGUuamF2YQ==) | `68.75% <0.00%> (-31.25%)` | :arrow_down: |
| ... and [16 more](https://codecov.io/gh/apache/shenyu/pull/4304?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] yu199195 merged pull request #4304: [ISSUE #4208] Refactored Sign-plugin
Posted by GitBox <gi...@apache.org>.
yu199195 merged PR #4304:
URL: https://github.com/apache/shenyu/pull/4304
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org