You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Florian Barca <fb...@hortonworks.com> on 2015/05/29 02:26:40 UTC

Review Request 34792: [WinTP2] HDP 2.3 stack: Tez service fails to start

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34792/
-----------------------------------------------------------

Review request for Ambari, Artem Baranchuk and Jayush Luniya.


Bugs: AMBARI-11513
    https://issues.apache.org/jira/browse/AMBARI-11513


Repository: ambari


Description
-------

+Fixed Tez settings generation
+Fixed Tez service check dependency order


Diffs
-----

  ambari-common/src/main/python/ambari_commons/os_utils.py 5ee34a8325002d4fa1407c58424a9252386f6cac 
  ambari-common/src/main/python/resource_management/libraries/functions/get_hdp_version.py ec30dc43dae88599291382452f38a22f7f0301e7 
  ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_windows.py 2a7bd8b5ee6c5e6f467f4ea57e0af00f540fdbc7 
  ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py e6c92e1ea6ccf44cf791d8384e4b1dffb7111c28 
  ambari-server/src/main/resources/stacks/HDPWIN/2.1/role_command_order.json dc555339064ba4903dd1c3ca31c93647adcf5461 
  ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/TEZ/configuration/tez-env.xml fd7e7b08528b3de877c6cc90fb6a9b3ab5a13428 
  ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/TEZ/configuration/tez-site.xml 50345fd9fd2cb0b6cc0ef2fc84fbbf05e0a3b72b 
  ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/HIVE/configuration/hive-site.xml b83c706227239b30ea3b4c2c23c480d502ae1ded 
  ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/TEZ/configuration/tez-site.xml be534f14ec727a5f87501aa51d496a7f699238db 

Diff: https://reviews.apache.org/r/34792/diff/


Testing
-------

local VM cluster deployment -> all green


Thanks,

Florian Barca


Re: Review Request 34792: [WinTP2] HDP 2.3 stack: Tez service fails to start

Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34792/#review85740
-----------------------------------------------------------

Ship it!


Ship It!

- Jayush Luniya


On May 29, 2015, 12:26 a.m., Florian Barca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34792/
> -----------------------------------------------------------
> 
> (Updated May 29, 2015, 12:26 a.m.)
> 
> 
> Review request for Ambari, Artem Baranchuk and Jayush Luniya.
> 
> 
> Bugs: AMBARI-11513
>     https://issues.apache.org/jira/browse/AMBARI-11513
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> +Fixed Tez settings generation
> +Fixed Tez service check dependency order
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/ambari_commons/os_utils.py 5ee34a8325002d4fa1407c58424a9252386f6cac 
>   ambari-common/src/main/python/resource_management/libraries/functions/get_hdp_version.py ec30dc43dae88599291382452f38a22f7f0301e7 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_windows.py 2a7bd8b5ee6c5e6f467f4ea57e0af00f540fdbc7 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py e6c92e1ea6ccf44cf791d8384e4b1dffb7111c28 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/role_command_order.json dc555339064ba4903dd1c3ca31c93647adcf5461 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/TEZ/configuration/tez-env.xml fd7e7b08528b3de877c6cc90fb6a9b3ab5a13428 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/TEZ/configuration/tez-site.xml 50345fd9fd2cb0b6cc0ef2fc84fbbf05e0a3b72b 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/HIVE/configuration/hive-site.xml b83c706227239b30ea3b4c2c23c480d502ae1ded 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/TEZ/configuration/tez-site.xml be534f14ec727a5f87501aa51d496a7f699238db 
> 
> Diff: https://reviews.apache.org/r/34792/diff/
> 
> 
> Testing
> -------
> 
> local VM cluster deployment -> all green
> 
> 
> Thanks,
> 
> Florian Barca
> 
>


Re: Review Request 34792: [WinTP2] HDP 2.3 stack: Tez service fails to start

Posted by Florian Barca <fb...@hortonworks.com>.

> On May 29, 2015, 3:52 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py, line 84
> > <https://reviews.apache.org/r/34792/diff/1/?file=973964#file973964line84>
> >
> >     Do we really need lzo to be configured by default?

This is the similar default with the one in Linux. The setting itself is cumbersome, so it's either this, or thorough documentation.


- Florian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34792/#review85739
-----------------------------------------------------------


On May 29, 2015, 12:26 a.m., Florian Barca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34792/
> -----------------------------------------------------------
> 
> (Updated May 29, 2015, 12:26 a.m.)
> 
> 
> Review request for Ambari, Artem Baranchuk and Jayush Luniya.
> 
> 
> Bugs: AMBARI-11513
>     https://issues.apache.org/jira/browse/AMBARI-11513
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> +Fixed Tez settings generation
> +Fixed Tez service check dependency order
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/ambari_commons/os_utils.py 5ee34a8325002d4fa1407c58424a9252386f6cac 
>   ambari-common/src/main/python/resource_management/libraries/functions/get_hdp_version.py ec30dc43dae88599291382452f38a22f7f0301e7 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_windows.py 2a7bd8b5ee6c5e6f467f4ea57e0af00f540fdbc7 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py e6c92e1ea6ccf44cf791d8384e4b1dffb7111c28 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/role_command_order.json dc555339064ba4903dd1c3ca31c93647adcf5461 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/TEZ/configuration/tez-env.xml fd7e7b08528b3de877c6cc90fb6a9b3ab5a13428 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/TEZ/configuration/tez-site.xml 50345fd9fd2cb0b6cc0ef2fc84fbbf05e0a3b72b 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/HIVE/configuration/hive-site.xml b83c706227239b30ea3b4c2c23c480d502ae1ded 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/TEZ/configuration/tez-site.xml be534f14ec727a5f87501aa51d496a7f699238db 
> 
> Diff: https://reviews.apache.org/r/34792/diff/
> 
> 
> Testing
> -------
> 
> local VM cluster deployment -> all green
> 
> 
> Thanks,
> 
> Florian Barca
> 
>


Re: Review Request 34792: [WinTP2] HDP 2.3 stack: Tez service fails to start

Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34792/#review85739
-----------------------------------------------------------



ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py
<https://reviews.apache.org/r/34792/#comment137484>

    Do we really need lzo to be configured by default?


- Jayush Luniya


On May 29, 2015, 12:26 a.m., Florian Barca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34792/
> -----------------------------------------------------------
> 
> (Updated May 29, 2015, 12:26 a.m.)
> 
> 
> Review request for Ambari, Artem Baranchuk and Jayush Luniya.
> 
> 
> Bugs: AMBARI-11513
>     https://issues.apache.org/jira/browse/AMBARI-11513
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> +Fixed Tez settings generation
> +Fixed Tez service check dependency order
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/ambari_commons/os_utils.py 5ee34a8325002d4fa1407c58424a9252386f6cac 
>   ambari-common/src/main/python/resource_management/libraries/functions/get_hdp_version.py ec30dc43dae88599291382452f38a22f7f0301e7 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_windows.py 2a7bd8b5ee6c5e6f467f4ea57e0af00f540fdbc7 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py e6c92e1ea6ccf44cf791d8384e4b1dffb7111c28 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/role_command_order.json dc555339064ba4903dd1c3ca31c93647adcf5461 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/TEZ/configuration/tez-env.xml fd7e7b08528b3de877c6cc90fb6a9b3ab5a13428 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/TEZ/configuration/tez-site.xml 50345fd9fd2cb0b6cc0ef2fc84fbbf05e0a3b72b 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/HIVE/configuration/hive-site.xml b83c706227239b30ea3b4c2c23c480d502ae1ded 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/TEZ/configuration/tez-site.xml be534f14ec727a5f87501aa51d496a7f699238db 
> 
> Diff: https://reviews.apache.org/r/34792/diff/
> 
> 
> Testing
> -------
> 
> local VM cluster deployment -> all green
> 
> 
> Thanks,
> 
> Florian Barca
> 
>


Re: Review Request 34792: [WinTP2] HDP 2.3 stack: Tez service fails to start

Posted by Artem Baranchuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34792/#review85710
-----------------------------------------------------------

Ship it!


Ship It!

- Artem Baranchuk


On Май 29, 2015, 12:26 д.п., Florian Barca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34792/
> -----------------------------------------------------------
> 
> (Updated Май 29, 2015, 12:26 д.п.)
> 
> 
> Review request for Ambari, Artem Baranchuk and Jayush Luniya.
> 
> 
> Bugs: AMBARI-11513
>     https://issues.apache.org/jira/browse/AMBARI-11513
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> +Fixed Tez settings generation
> +Fixed Tez service check dependency order
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/ambari_commons/os_utils.py 5ee34a8325002d4fa1407c58424a9252386f6cac 
>   ambari-common/src/main/python/resource_management/libraries/functions/get_hdp_version.py ec30dc43dae88599291382452f38a22f7f0301e7 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_windows.py 2a7bd8b5ee6c5e6f467f4ea57e0af00f540fdbc7 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py e6c92e1ea6ccf44cf791d8384e4b1dffb7111c28 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/role_command_order.json dc555339064ba4903dd1c3ca31c93647adcf5461 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/TEZ/configuration/tez-env.xml fd7e7b08528b3de877c6cc90fb6a9b3ab5a13428 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/TEZ/configuration/tez-site.xml 50345fd9fd2cb0b6cc0ef2fc84fbbf05e0a3b72b 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/HIVE/configuration/hive-site.xml b83c706227239b30ea3b4c2c23c480d502ae1ded 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/TEZ/configuration/tez-site.xml be534f14ec727a5f87501aa51d496a7f699238db 
> 
> Diff: https://reviews.apache.org/r/34792/diff/
> 
> 
> Testing
> -------
> 
> local VM cluster deployment -> all green
> 
> 
> Thanks,
> 
> Florian Barca
> 
>


Re: Review Request 34792: [WinTP2] HDP 2.3 stack: Tez service fails to start

Posted by Jayush Luniya <jl...@hortonworks.com>.

> On May 29, 2015, 8:17 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/TEZ/configuration/tez-site.xml, line 36
> > <https://reviews.apache.org/r/34792/diff/1/?file=973969#file973969line36>
> >
> >     Hmm, would a file path work in multi-node deployment?

Nevermind, with the msi tez tarball will be on every host.


- Jayush


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34792/#review85695
-----------------------------------------------------------


On May 29, 2015, 12:26 a.m., Florian Barca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34792/
> -----------------------------------------------------------
> 
> (Updated May 29, 2015, 12:26 a.m.)
> 
> 
> Review request for Ambari, Artem Baranchuk and Jayush Luniya.
> 
> 
> Bugs: AMBARI-11513
>     https://issues.apache.org/jira/browse/AMBARI-11513
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> +Fixed Tez settings generation
> +Fixed Tez service check dependency order
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/ambari_commons/os_utils.py 5ee34a8325002d4fa1407c58424a9252386f6cac 
>   ambari-common/src/main/python/resource_management/libraries/functions/get_hdp_version.py ec30dc43dae88599291382452f38a22f7f0301e7 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_windows.py 2a7bd8b5ee6c5e6f467f4ea57e0af00f540fdbc7 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py e6c92e1ea6ccf44cf791d8384e4b1dffb7111c28 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/role_command_order.json dc555339064ba4903dd1c3ca31c93647adcf5461 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/TEZ/configuration/tez-env.xml fd7e7b08528b3de877c6cc90fb6a9b3ab5a13428 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/TEZ/configuration/tez-site.xml 50345fd9fd2cb0b6cc0ef2fc84fbbf05e0a3b72b 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/HIVE/configuration/hive-site.xml b83c706227239b30ea3b4c2c23c480d502ae1ded 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/TEZ/configuration/tez-site.xml be534f14ec727a5f87501aa51d496a7f699238db 
> 
> Diff: https://reviews.apache.org/r/34792/diff/
> 
> 
> Testing
> -------
> 
> local VM cluster deployment -> all green
> 
> 
> Thanks,
> 
> Florian Barca
> 
>


Re: Review Request 34792: [WinTP2] HDP 2.3 stack: Tez service fails to start

Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34792/#review85695
-----------------------------------------------------------



ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/TEZ/configuration/tez-site.xml
<https://reviews.apache.org/r/34792/#comment137416>

    Hmm, would a file path work in multi-node deployment?


- Jayush Luniya


On May 29, 2015, 12:26 a.m., Florian Barca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34792/
> -----------------------------------------------------------
> 
> (Updated May 29, 2015, 12:26 a.m.)
> 
> 
> Review request for Ambari, Artem Baranchuk and Jayush Luniya.
> 
> 
> Bugs: AMBARI-11513
>     https://issues.apache.org/jira/browse/AMBARI-11513
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> +Fixed Tez settings generation
> +Fixed Tez service check dependency order
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/ambari_commons/os_utils.py 5ee34a8325002d4fa1407c58424a9252386f6cac 
>   ambari-common/src/main/python/resource_management/libraries/functions/get_hdp_version.py ec30dc43dae88599291382452f38a22f7f0301e7 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params_windows.py 2a7bd8b5ee6c5e6f467f4ea57e0af00f540fdbc7 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py e6c92e1ea6ccf44cf791d8384e4b1dffb7111c28 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/role_command_order.json dc555339064ba4903dd1c3ca31c93647adcf5461 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/TEZ/configuration/tez-env.xml fd7e7b08528b3de877c6cc90fb6a9b3ab5a13428 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/TEZ/configuration/tez-site.xml 50345fd9fd2cb0b6cc0ef2fc84fbbf05e0a3b72b 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/HIVE/configuration/hive-site.xml b83c706227239b30ea3b4c2c23c480d502ae1ded 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/TEZ/configuration/tez-site.xml be534f14ec727a5f87501aa51d496a7f699238db 
> 
> Diff: https://reviews.apache.org/r/34792/diff/
> 
> 
> Testing
> -------
> 
> local VM cluster deployment -> all green
> 
> 
> Thanks,
> 
> Florian Barca
> 
>