[GitHub] [incubator-doris] morningman commented on a change in pull request #7151: Optimize bitmap function count, use roaring cardinality method

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #7151:
URL: https://github.com/apache/incubator-doris/pull/7151#discussion_r754001296



##########
File path: be/src/exprs/bitmap_function.cpp
##########
@@ -333,10 +333,10 @@ BigIntVal BitmapFunctions::bitmap_count(FunctionContext* ctx, const StringVal& s
     // zero size means the src input is a agg object
     if (src.len == 0) {
         auto bitmap = reinterpret_cast<BitmapValue*>(src.ptr);
-        return {bitmap->cardinality()};
+        return static_cast<int64_t>(bitmap->cardinality());

Review comment:
       Is this more optimal?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org