Re: [PR] Mutable objects used for immutable values #772 [polaris]

["fabio-rizzo-01 (via GitHub)" <gi...@apache.org>]

fabio-rizzo-01 commented on PR #1596:
URL: https://github.com/apache/polaris/pull/1596#issuecomment-2886074876

   > @fabio-rizzo-01 I think the ask is that you use [this interface](https://github.com/apache/polaris/blob/2e373e51ce5434c26635535b684ff210a53b1745/tools/immutables/src/main/java/org/apache/polaris/immutables/PolarisImmutable.java#L39).
   > 
   > Besides this, I think we should try to minimize the changes that callers need to make as much as possible.
   
   Looking at that interface and seeing where it is used, it seems to me that using it would require even more changes that what I already did. 
   
   Taking PolarisEntityCore as an example, to convert that to an immutable object I'd have to create an interface (something like PolarisEntityCoreInt) that uses PolarisImmutable annotation, that would generate a class called Immutable PolarisEntityCoreInt. So all the code that is using PolarisEntityCore object it needs to be updated to use the new immutable object.
   
   Is this what you guys are suggesting ? @snazy @singhpk234 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org