[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27637: [SPARK-30874][SQL] Support Postgres Kerberos login in JDBC connector

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #27637: [SPARK-30874][SQL] Support Postgres Kerberos login in JDBC connector
URL: https://github.com/apache/spark/pull/27637#discussion_r381795251
 
 

 ##########
 File path: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/DockerJDBCIntegrationSuite.scala
 ##########
 @@ -62,10 +62,17 @@ abstract class DatabaseOnDocker {
    * Optional process to run when container starts
    */
   def getStartupProcessName: Option[String]
+
+  /**
+   * Optional step before container starts
+   */
+  def beforeContainerStart(hostConfigBuilder: HostConfig.Builder,
+      containerConfigBuilder: ContainerConfig.Builder): Unit = {}
 
 Review comment:
   nit. Could you put the first argument on the next line?
   ```scala
   def beforeContainerStart(
       hostConfigBuilder: HostConfig.Builder,
       containerConfigBuilder: ContainerConfig.Builder): Unit = {}
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org