You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/06/12 13:39:01 UTC

[jira] [Commented] (FLINK-6898) Limit size of operator component in metric name

    [ https://issues.apache.org/jira/browse/FLINK-6898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046569#comment-16046569 ] 

ASF GitHub Bot commented on FLINK-6898:
---------------------------------------

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/4109

    [FLINK-6898] [metrics] Limit size of operator component in metric name

    This PR prevents the operator name component of a metric name to exceed 80 characters. I picked 80 since it is below 255 (a common maximum for file lengths), but still large enough for that once-in-a-million special case. I guess.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 6898

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4109.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4109
    
----
commit 71bf096d6562d45a3b235ad8c027cdd601f6d937
Author: zentol <ch...@apache.org>
Date:   2017-06-12T13:36:25Z

    [FLINK-6898] [metrics] Limit size of operator component in metric name

----


> Limit size of operator component in metric name
> -----------------------------------------------
>
>                 Key: FLINK-6898
>                 URL: https://issues.apache.org/jira/browse/FLINK-6898
>             Project: Flink
>          Issue Type: Improvement
>          Components: Metrics
>    Affects Versions: 1.3.0, 1.4.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Critical
>             Fix For: 1.3.1, 1.4.0
>
>
> The operator name for some operators (specifically windows) can be very, very long (250+) characters.
> I propose to limit the total space that the operator component can take up in a metric name to 60 characters.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)