[GitHub] [accumulo] ctubbsii commented on a change in pull request #2140: Modify default compaction planner opts to include internal type

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #2140:
URL: https://github.com/apache/accumulo/pull/2140#discussion_r644790902



##########
File path: server/tserver/src/main/java/org/apache/accumulo/tserver/compactions/CompactionManager.java
##########
@@ -145,10 +145,11 @@ private long getDefaultThroughput(AccumuloConfiguration aconf) {
 
           HashMap<String,String> configsCopy = new HashMap<>(configs);
 
-          Map<String,String> defaultServiceConfigs =
-              Map.of(defaultServicePrefix + "planner", DefaultCompactionPlanner.class.getName(),
+          Map<String,
+              String> defaultServiceConfigs = Map.of(defaultServicePrefix + "planner",
+                  DefaultCompactionPlanner.class.getName(),
                   defaultServicePrefix + "planner.opts.executors",
-                  "[{'name':'deprecated','numThreads':" + numThreads + "}]");
+                  "[{'name':'deprecated', 'type':'internal', 'numThreads':" + numThreads + "}]");

Review comment:
       Rather than make this change, I think we should default to inferring an internal type when it is unspecified. Explicitly specifying `internal` should not be required.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org