You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/10/02 18:53:57 UTC
Review Request 62730: Used `TRUE|FALSE` instead of `ON|OFF`
consistently in CMake.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62730/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Jeff Coffler, John Kordich, Joseph Wu, and Li Li.
Bugs: MESOS-3107
https://issues.apache.org/jira/browse/MESOS-3107
Repository: mesos
Description
-------
While these are equivalent values to CMake, we should be consistent.
Also made uses of `option` consistent, and moved `ENABLE_JAVA` to the
3rdparty section.
Diffs
-----
cmake/CompilationConfigure.cmake 4cb8dddf93694722af2377c4a55a195260c8a0cb
Diff: https://reviews.apache.org/r/62730/diff/1/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 62730: Used `TRUE|FALSE` instead of `ON|OFF`
consistently in CMake.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62730/#review186886
-----------------------------------------------------------
FYI I could go either way on this. `TRUE|FALSE` or `ON|OFF`. We should just be consistent.
- Andrew Schwartzmeyer
On Oct. 2, 2017, 11:53 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62730/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2017, 11:53 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jeff Coffler, John Kordich, Joseph Wu, and Li Li.
>
>
> Bugs: MESOS-3107
> https://issues.apache.org/jira/browse/MESOS-3107
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While these are equivalent values to CMake, we should be consistent.
> Also made uses of `option` consistent, and moved `ENABLE_JAVA` to the
> 3rdparty section.
>
>
> Diffs
> -----
>
> cmake/CompilationConfigure.cmake 9707e88fad29503e3205b8e25e8e625abfb60179
>
>
> Diff: https://reviews.apache.org/r/62730/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 62730: Used `TRUE|FALSE` instead of `ON|OFF`
consistently in CMake.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62730/#review186891
-----------------------------------------------------------
Ship it!
True/false is a decent choice.
- Joseph Wu
On Oct. 2, 2017, 11:53 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62730/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2017, 11:53 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jeff Coffler, John Kordich, Joseph Wu, and Li Li.
>
>
> Bugs: MESOS-3107
> https://issues.apache.org/jira/browse/MESOS-3107
>
>
> Repository: mesos
>
>
> Description
> -------
>
> While these are equivalent values to CMake, we should be consistent.
> Also made uses of `option` consistent, and moved `ENABLE_JAVA` to the
> 3rdparty section.
>
>
> Diffs
> -----
>
> cmake/CompilationConfigure.cmake 9707e88fad29503e3205b8e25e8e625abfb60179
>
>
> Diff: https://reviews.apache.org/r/62730/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>