You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/02/23 10:49:09 UTC
[GitHub] [hive] vcsomor opened a new pull request #3047: HIVE-25973: Fix JsonReporter and JsonFileMetricsReporter writing the same file
vcsomor opened a new pull request #3047:
URL: https://github.com/apache/hive/pull/3047
The JsonReporter and JsonFileMetricsReporter writing the same file.
This issue is caused by the HIVE-25842.
Since the Metrics is launching also a JmxExporter the `MetricsFactory.init(conf);` is unnecessary in the HiveMetaStore the delta metrics will be exposed.
### How was this patch tested?
This test has been tested manually by checking the JMX console for the reported obsolete delta metrics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] vcsomor commented on a change in pull request #3047: HIVE-25973: Fix JsonReporter and JsonFileMetricsReporter writing the same file
Posted by GitBox <gi...@apache.org>.
vcsomor commented on a change in pull request #3047:
URL: https://github.com/apache/hive/pull/3047#discussion_r812928371
##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/metrics/AcidMetricService.java
##########
@@ -263,30 +262,27 @@ public static void updateMetricsFromCleaner(String dbName, String tableName, Str
}
private void updateDeltaMetrics() {
- org.apache.hadoop.hive.common.metrics.common.Metrics metrics = MetricsFactory.getInstance();
Review comment:
I've had to remove this as well @lcspinter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] lcspinter merged pull request #3047: HIVE-25973: Fix JsonReporter and JsonFileMetricsReporter writing the same file
Posted by GitBox <gi...@apache.org>.
lcspinter merged pull request #3047:
URL: https://github.com/apache/hive/pull/3047
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org