[jira] [Comment Edited] (KAFKA-5289) One StopReplicaRequest will caused two Responses

["xuzq (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-5289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017098#comment-16017098 ] 

xuzq edited comment on KAFKA-5289 at 5/19/17 9:10 AM:
------------------------------------------------------

We overwrote the  ReplicaFetcherManager class, and threw an exception in method shutdownIdleFetcherThreads(). 
In the original code, an exception will be threw in fetcher.shutdown(), such as InterruptedException when the thread interrupted.


was (Author: xuzq_zander):
We overwrote the  ReplicaFetcherManager class, and threw an exception in method shutdownIdleFetcherThreads(). 
In the original code, an exceptions will be threw in fetcher.shutdown(), such as InterruptedException when the thread interrupted.

> One StopReplicaRequest will caused two Responses
> ------------------------------------------------
>
>                 Key: KAFKA-5289
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5289
>             Project: Kafka
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 0.10.0.0
>            Reporter: xuzq
>            Priority: Critical
>         Attachments: handleStopReplicaRequest.png
>
>
> After discussed with my friend markTC，we find a bug.
> One StopReplicaRequest will caused two Responses.
> At core/src/main/scala/kafka/server/KafkaApi.class 175 and 176 lines.
> When an exception caused at 'replicaManager.replicaFetcherManager.shutdownIdleFetcherThreads()', 
> will also return two responses.
> one is at 175 lines 'requestChannel.sendResponse(new RequestChannel.Response(request, new ResponseSend(request.connectionId, responseHeader, response)))' and another at 111 lines 'requestChannel.sendResponse(new Response(request, new ResponseSend(request.connectionId, respHeader, response)))'.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)