You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "wu-sheng (via GitHub)" <gi...@apache.org> on 2023/02/06 02:48:15 UTC

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10287: [Elasticsearch] Support batchOfBytes configuration to limit size of bulk flush.

wu-sheng commented on code in PR #10287:
URL: https://github.com/apache/skywalking/pull/10287#discussion_r1096897918


##########
docs/en/setup/backend/configuration-vocabulary.md:
##########
@@ -106,6 +106,7 @@ The Configuration Vocabulary lists all available configurations provided by `app
 | -                       | -             | superDatasetIndexReplicasNumber                                                                                                                                          | Represents the replicas number in the super size dataset record index.                                                                                                                                                                                                                                                                                                                                                                                          | SW_STORAGE_ES_SUPER_DATASET_INDEX_REPLICAS_NUMBER | 0                                                                                            |
 | -                       | -             | indexTemplateOrder                                                                                                                                                       | The order of index template.                                                                                                                                                                                                                                                                                                                                                                                                                                    | SW_STORAGE_ES_INDEX_TEMPLATE_ORDER                | 0                                                                                            |
 | -                       | -             | bulkActions                                                                                                                                                              | Async bulk size of the record data batch execution.                                                                                                                                                                                                                                                                                                                                                                                                             | SW_STORAGE_ES_BULK_ACTIONS                        | 5000                                                                                         |
+| -                       | -              | batchOfBytes                                                                                                                                                             | A threshold to control the max body size of ElasticSearch Bulk flush.                                                                                                                                                                                                                                                                                                                           | SW_STORAGE_ES_BATCH_OF_BYTES                      | 5242880                                                                                      |

Review Comment:
   ```suggestion
   | -                       | -              | batchOfBytes                                                                                                                                                             | A threshold to control the max body size of ElasticSearch Bulk flush.                                                                                                                                                                                                                                                                                                                           | SW_STORAGE_ES_BATCH_OF_BYTES                      | 10485760  (10m)                                                                                    |
   ```
   Do you miss this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org