[jira] [Commented] (CASSANDRA-16025) Cqlsh unit testing and coverage improvements

["Berenguer Blasi (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-16025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17320684#comment-17320684 ] 

Berenguer Blasi commented on CASSANDRA-16025:
---------------------------------------------

Hi [~bhouser],

I saw you pinged me on Slack but I didn't want to reply there as I don't know your TZ. You were asking:

bq. what would constitute a success?  how many tests/coverage would we be after for the ticket to be closed?

We define what we consider success or acceptance criteria etc. We are driving. I can make a quick draft of how _I_ would go about as inspiration and you tell me what do you think or if you have some other idea:
# Grep somehow how many cqlsh unit tests we have spread around: dtests, jvm-dtests, cqlsh tests, junits etc.
# Go through them in diagonal and make sure they could all be ported to junit and tested with {{ToolRunner}} introduced in 15583.
# Circulate the idea in the dev mailing list to make sure I am not missing anything or doing sthg silly.
# Consolidate everything into junits. That should remove lots of code from everything not junit and simplify the overall project and test workflows.
#* I would avoid a big-bang approach. I would migrate one 'area' or functionality at a time via tickets.
#* I would prefer smaller tickets that get merged than long running mammoth ones that take ages.
# While doing the above document what is covered and what is missing.
# Create tickets for the missing bits and label those that I feel are LHF.

Wdyt?



> Cqlsh unit testing and coverage improvements
> --------------------------------------------
>
>                 Key: CASSANDRA-16025
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16025
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tool/cqlsh
>            Reporter: Berenguer Blasi
>            Priority: Normal
>             Fix For: 4.0.x
>
>
> Nowadays the majority of cqlsh testing happens outside the main java unit testing effort. A lot is done as separate cqlsh tests, dtests, python, etc.
> The purpose of this ticket is to improve unit test coverage as much as possible now that CASSANDRA-15583 allows us to perform java unit tests for the tool.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org