You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/06/23 03:50:44 UTC

[GitHub] [camel-k] tadayosi opened a new pull request, #3386: fix(build): tidy submodules and make their tests run in build

tadayosi opened a new pull request, #3386:
URL: https://github.com/apache/camel-k/pull/3386

   <!-- Description -->
   
   I found out that the tests under these 3 dirs are ignored during build and test:
   - `pkg/apis/camel`
   - `pkg/client/camel`
   - `pkg/kamelet/repository`
   because they have their own `go.mod` module definitions.
   
   This updated the module definitions and put them in the test process.
   
   <!--
   Enter your extended release note in the below block. If the PR requires
   additional action from users switching to the new release, include the string
   "action required". If no release note is required, write "NONE". 
   
   You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
   the text is added to the right section of the release notes. 
   -->
   
   **Release Note**
   ```release-note
   NONE
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] tadayosi merged pull request #3386: fix(build): tidy submodules and make their tests run in build

Posted by GitBox <gi...@apache.org>.

tadayosi merged PR #3386:
URL: https://github.com/apache/camel-k/pull/3386


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] astefanutti commented on pull request #3386: fix(build): tidy submodules and make their tests run in build

Posted by GitBox <gi...@apache.org>.

astefanutti commented on PR #3386:
URL: https://github.com/apache/camel-k/pull/3386#issuecomment-1164110832

   > LGTM. I am wondering if it makes sense to have them a different set of dependencies and why not using the base ones. @astefanutti do you know why they are structured this way?
   
   @squakez APIs and clients have their own modules, so consumers do not have to depend on the main operator module, which is rather internal and should not be depended on conceptually. I think that's an accepted best practice among the operators ecosystem.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org