[GitHub] incubator-hawq pull request: HAWQ-703. Serialize HCatalog Complex ...

[shivzone <gi...@git.apache.org>]

Github user shivzone commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/633#discussion_r61800082
  
    --- Diff: pxf/pxf-api/src/main/java/org/apache/hawq/pxf/api/Metadata.java ---
    @@ -67,36 +68,43 @@ public String toString() {
         }
     
         /**
    -     * Class representing item field - name and type.
    +     * Class representing item field - name, type, source type, modifiers.
    +     * Type - exposed type of field
    +     * Source type - type of field in underlying source
    +     * Modifiers - additional attributes which describe type or field
          */
         public static class Field {
             private String name;
    -        private String type; // TODO: change to enum
    +        private EnumHawqType type; // field type which PXF exposes
    +        private String sourceType; // filed type PXF reads from
             private String[] modifiers; // type modifiers, optional field
     
    -        public Field(String name, String type) {
    -
    -            if (StringUtils.isBlank(name) || StringUtils.isBlank(type)) {
    -                throw new IllegalArgumentException("Field name and type cannot be empty");
    -            }
    -
    -            this.name = name;
    -            this.type = type;
    +    public Field(String name, EnumHawqType type, String sourceType) {
    --- End diff --
    
    Correct indentation in Field class


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---