[GitHub] [pulsar] michaeljmarshall commented on a change in pull request #14098: [test] Replace PowerMockito#mockStatic usages with mockito-inline

[GitBox <gi...@apache.org>]

michaeljmarshall commented on a change in pull request #14098:
URL: https://github.com/apache/pulsar/pull/14098#discussion_r803017724



##########
File path: pulsar-common/src/main/java/org/apache/pulsar/common/protocol/Commands.java
##########
@@ -578,7 +578,7 @@ public static ByteBuf newSubscribe(String topic, String subscription, long consu
                 keyValue.setValue(value);
                 keyValues.add(keyValue);
             });
-            subscribe.addAllSubscriptionProperties(keyValues);
+            // subscribe.addAllSubscriptionProperties(keyValues);

Review comment:
       Same question.

##########
File path: pulsar-common/src/main/java/org/apache/pulsar/common/protocol/Commands.java
##########
@@ -180,7 +180,7 @@ public static ByteBuf newConnect(String authMethodName, String authData, String
     private static void setFeatureFlags(FeatureFlags flags) {
         flags.setSupportsAuthRefresh(true);
         flags.setSupportsBrokerEntryMetadata(true);
-        flags.setSupportsPartialProducer(true);
+        // flags.setSupportsPartialProducer(true);

Review comment:
       What is the purpose of leaving this as a comment?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org