[GitHub] [druid] cryptoe commented on pull request #13926: Adding query stack fault to MSQ to capture native query errors.

["cryptoe (via GitHub)" <gi...@apache.org>]

cryptoe commented on PR #13926:
URL: https://github.com/apache/druid/pull/13926#issuecomment-1467507516

   I earlier made changes in BaseLeafFrameProcessor#runIncrementally method but since that would also throw FrameSpecific exceptions I dropped that idea. 
   
   
   > There is a new error code QueryStackError that is only used in one case: when the query stack throws UnexpectedMultiValueDimensionException. Did you mean to associate this error code with more kinds of problems?
   
   I was thinking we would eventually add more errors and `UnexpectedMultiValueDimensionException` is just the start. 
   
   Another approach was to get the exception and check if the exception class name starts with `org.apache.druid.query` . It might be a hack but it may work for about 10 exceptions. WDYT ?
   
   <img width="611" alt="Screenshot 2023-03-14 at 12 42 18 PM" src="https://user-images.githubusercontent.com/2260045/224923303-d70356e4-bf8f-40b9-810e-804efc0baa99.png">
   
   > If we keep this design, also, to me QueryRuntimeError makes more sense than QueryStackError
   
   Sure I can rename `QueryStackError` to `QueryRuntimeError`. 
   
   
    


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org