You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by fh...@apache.org on 2007/12/14 20:39:14 UTC
svn commit: r604274 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: fhanik
Date: Fri Dec 14 11:39:13 2007
New Revision: 604274
URL: http://svn.apache.org/viewvc?rev=604274&view=rev
Log:
vote and proposal
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=604274&r1=604273&r2=604274&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Fri Dec 14 11:39:13 2007
@@ -33,5 +33,27 @@
* Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=44041
http://svn.apache.org/viewvc?rev=603340&view=rev
- +1: markt, jim
+ +1: markt, jim, fhanik
-1:
+
+* Fix chunked encoding parsing
+ The following patch fixes how the Comet processors blocks, it doesn't change the
+ way chunked parsing is done, but changing when it blocks and doesn't block.
+ In the old way, it incorrectly blocks after parsing CRLF waiting for the next chunk
+ In the new way, it wont block after CRLF
+ Index: java/org/apache/coyote/http11/filters/ChunkedInputFilter.java
+ ===================================================================
+ --- java/org/apache/coyote/http11/filters/ChunkedInputFilter.java (revision 604269)
+ +++ java/org/apache/coyote/http11/filters/ChunkedInputFilter.java (working copy)
+ @@ -154,7 +154,7 @@
+ chunk.setBytes(buf, pos, remaining);
+ pos = pos + remaining;
+ remaining = 0;
+ - needCRLFParse = true;
+ + parseCRLF(); //a chunk should end with CRLF, block right away
+ }
+
+ return result;
+
+ +1: fhanik
+ -1:
\ No newline at end of file
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org