You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/08/12 16:57:14 UTC

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #4332: fs: Support 64bit in register_[block|mtd]partition

gustavonihei commented on a change in pull request #4332:
URL: https://github.com/apache/incubator-nuttx/pull/4332#discussion_r687923958



##########
File path: fs/driver/fs_blockpartition.c
##########
@@ -43,8 +43,8 @@
 struct part_struct_s
 {
   FAR struct inode *parent;
-  size_t firstsector;
-  size_t nsectors;
+  off_t firstsector;
+  off_t nsectors;

Review comment:
       `nsectors` represents a quantity, it is not an actual offset.
   It seems conceptually wrong to change it to `off_t`. It should be left as `size_t`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org