[GitHub] [skywalking] wu-sheng commented on a diff in pull request #9855: Add virtual MQ analysis for native traces

[GitBox <gi...@apache.org>]

wu-sheng commented on code in PR #9855:
URL: https://github.com/apache/skywalking/pull/9855#discussion_r1006348605


##########
oap-server/server-starter/src/main/resources/oal/core.oal:
##########
@@ -25,8 +25,6 @@ service_sla = from(Service.*).percent(status == true);
 service_cpm = from(Service.*).cpm();
 service_percentile = from(Service.latency).percentile(10); // Multiple values including p50, p75, p90, p95, p99
 service_apdex = from(Service.latency).apdex(name, status);
-service_mq_consume_count = from(Service.*).filter(type == RequestType.MQ).count();

Review Comment:
   I think these should be kept. As this is still meaningful from a service perspective.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org