You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/12/16 16:00:06 UTC

[GitHub] [kafka] dajac commented on pull request #12997: KAFKA-14492: Extract a method to create LogManager, in order to be overrided by subclass of KafkaServer

dajac commented on PR #12997:
URL: https://github.com/apache/kafka/pull/12997#issuecomment-1355137463

   Thanks for the PR. It is important to note that `KafkaServer` is not considered as a public interface in Kafka. Hence, there is not guarantee that the interface will remain like this in the future. It can basically change anytime. Therefore, I am personally not comfortable with this change. Have you considered alternative approaches? @ijuma What do you think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org