[GitHub] [gobblin] vikrambohra commented on a change in pull request #3398: [GOBBLIN-1547] Set completion watermark to end of hour instead of beg…

[GitBox <gi...@apache.org>]

vikrambohra commented on a change in pull request #3398:
URL: https://github.com/apache/gobblin/pull/3398#discussion_r711240830



##########
File path: gobblin-iceberg/src/main/java/org/apache/gobblin/iceberg/writer/IcebergMetadataWriter.java
##########
@@ -729,9 +729,9 @@ private StructLike addLatePartitionValueToIcebergTable(Table table, TableMetadat
   private int isLate(String datepartition, long previousWatermark) {
     ZonedDateTime partitionDateTime = ZonedDateTime.parse(datepartition, HOURLY_DATEPARTITION_FORMAT);
     long partitionEpochTime = partitionDateTime.toInstant().toEpochMilli();
-    if(partitionEpochTime > previousWatermark) {
+    if(partitionEpochTime >= previousWatermark) {

Review comment:
       if CW = 9am then data for datepartition <= 8am is complete and datepartion>=9 is still not complete (so late =0)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org