[GitHub] garrensmith commented on a change in pull request #1126: Sidebar redux refactoring

[GitBox <gi...@apache.org>]

garrensmith commented on a change in pull request #1126: Sidebar redux refactoring
URL: https://github.com/apache/couchdb-fauxton/pull/1126#discussion_r221613836
 
 

 ##########
 File path: app/addons/documents/sidebar/SidebarControllerContainer.js
 ##########
 @@ -12,25 +12,102 @@
 
 import { connect } from 'react-redux';
 import SidebarComponents from './sidebar';
-import ActionTypes from './actiontypes';
+import Action from './actions';
 
-const reduxUpdatedDesignDocList = (designDocs) => {
-  return {
-    type: ActionTypes.SIDEBAR_UPDATED_DESIGN_DOCS,
-    options: {
-      designDocs: Array.isArray(designDocs) ? designDocs : []
-    }
+const getDatabase = (state) => {
 
 Review comment:
   I think to be consistent with how we have done redux elsewhere these should go into the reducer file for sidebars.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services