[jira] [Commented] (HDDS-5867) Update quota when deleting open keys

["Ethan Rose (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDDS-5867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517758#comment-17517758 ] 

Ethan Rose commented on HDDS-5867:
----------------------------------

Hi [~ckj] [~micahzhao] I know I did not have time to properly review this before it was merged, but I think there may be some problems with the current implementation. I see that we are doing quota updates to the bucket in OMOpenKeysDeleteRequest. I do not think this is correct, as the bucket may no longer exist when the open key is being deleted, or may have been deleted and re-created with the same name. The later would lead to an incorrect quota update for that new bucket when the open key is deleted.

Could you explain why we are doing quota updates as part of open key cleanup? My understanding is that Ozone's committed data is the source of truth, so quota updates should happen only when a key is committed.

> Update quota when deleting open keys
> ------------------------------------
>
>                 Key: HDDS-5867
>                 URL: https://issues.apache.org/jira/browse/HDDS-5867
>             Project: Apache Ozone
>          Issue Type: Sub-task
>            Reporter: mingchao zhao
>            Assignee: Kaijie Chen
>            Priority: Major
>              Labels: pull-request-available
>
> In HDDS-4120, we plan to delete expired data in Open key Tables. Request and Response are implemented in HDDS-4122.
> But we did not update UsedBytes and UsedNamespace in new request, we need to fix this problem.
> When these keys are deleted, the UsedBytes and UsedNamespace also need to be updated.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org