[jira] [Commented] (HTRACE-146) Search page: Remove client-side sorting and improve pagination

["Colin Patrick McCabe (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HTRACE-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14391727#comment-14391727 ] 

Colin Patrick McCabe commented on HTRACE-146:
---------------------------------------------

There is an existing bug where we are assuming that span results are sorted by span ID, whereas they may be sorted by other things such as begin time.  To fix this, we will probably want to have the GUI send back the entire previous span as a kind of continuation token.

This patch doesn't address that issue.  However, abe and I talked about this offline and I think this patch is a good incremental step.  So +1 from me... thanks, [~abec].

> Search page: Remove client-side sorting and improve pagination
> --------------------------------------------------------------
>
>                 Key: HTRACE-146
>                 URL: https://issues.apache.org/jira/browse/HTRACE-146
>             Project: HTrace
>          Issue Type: Sub-task
>            Reporter: Abraham Elmahrek
>            Assignee: Abraham Elmahrek
>              Labels: ui
>             Fix For: 3.2.0
>
>         Attachments: HTRACE-146.001.patch, HTRACE-146.002.patch
>
>
> Search page sorting doesn't really work because it is in infinite scroll mode.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)