[GitHub] leanken edited a comment on issue #6863: [FLINK-10166][table] skip relocation of commons-codec and commons-lang3 from flink-table

[GitBox <gi...@apache.org>]

leanken edited a comment on issue #6863: [FLINK-10166][table] skip relocation of commons-codec and commons-lang3 from flink-table
URL: https://github.com/apache/flink/pull/6863#issuecomment-430521113
 
 
   > Hi @leanken . Thank you for your contribution. I am afraid though it is not the right way to proceed with this bug. I think we should rather cut off usage of `Base64` (replace with our own implementation) than add hard external dependencies.
   ---- "reply: for Base64 replacement. I think it's ok for just this single case, what if there are even more cases like Base64, in future, we might need to do the replacement case by case"
   > 
   > Also just to clarify why we relocate dependencies. The reason is not just so they do not clash with other dependencies of ours (e.g. from calcite as you said), but also so that Flink's users can use any arbitrary version of popular libraries.
   ---- "reply: the reason that you mentioned, user can use any version of org.apache.commons prefix library, I dont think it is now working, because in flink-binary-with-hadoop common-codec library already included in classpath, even if FlinkUserJar contains its own common-codec jar, it might be conflict during runtime"
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services