You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "xintongsong (via GitHub)" <gi...@apache.org> on 2023/08/01 06:40:05 UTC
[GitHub] [flink] xintongsong commented on a diff in pull request #23026: [FLINK-32558][flink-java] Deprecate all DataSet API
xintongsong commented on code in PR #23026:
URL: https://github.com/apache/flink/pull/23026#discussion_r1280146390
##########
flink-examples/flink-examples-batch/pom.xml:
##########
@@ -48,25 +48,6 @@ under the License.
<build>
<plugins>
- <!-- Fail compilation on deprecation warnings to prevent from showing users outdated examples. -->
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-compiler-plugin</artifactId>
- <executions>
- <execution>
- <id>compile</id>
- <phase>process-sources</phase>
- <goals>
- <goal>compile</goal>
- </goals>
- <configuration>
- <compilerArgument>-Xlint:deprecation</compilerArgument>
- <failOnWarning>true</failOnWarning>
- </configuration>
- </execution>
- </executions>
- </plugin>
-
Review Comment:
I wonder if we should simply remove this module. The original purpose is to not showing user outdated examples. With DataSet API being deprecated, we don't want any newcomers to use it.
##########
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java:
##########
@@ -556,7 +556,14 @@ public void setExecutionMode(ExecutionMode executionMode) {
* <p>The default execution mode is {@link ExecutionMode#PIPELINED}.
*
* @return The execution mode for the program.
+ * @deprecated All Flink DataSet APIs are deprecated since Flink 1.18 and will be removed in a
+ * future Flink major version. You can still build your application in DataSet, but you
+ * should move to either the DataStream and/or Table API.
+ * @see <a href="https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=158866741">
+ * FLIP-131: Consolidate the user-facing Dataflow SDKs/APIs (and deprecate the DataSet
+ * API</a>
*/
+ @Deprecated
Review Comment:
Shouldn't we also deprecated the class `ExecutionMode` and the method `setExecutionMode`?
##########
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java:
##########
@@ -556,7 +556,14 @@ public void setExecutionMode(ExecutionMode executionMode) {
* <p>The default execution mode is {@link ExecutionMode#PIPELINED}.
*
* @return The execution mode for the program.
+ * @deprecated All Flink DataSet APIs are deprecated since Flink 1.18 and will be removed in a
+ * future Flink major version. You can still build your application in DataSet, but you
+ * should move to either the DataStream and/or Table API.
+ * @see <a href="https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=158866741">
+ * FLIP-131: Consolidate the user-facing Dataflow SDKs/APIs (and deprecate the DataSet
+ * API</a>
*/
+ @Deprecated
Review Comment:
Also, there are some descriptions about the execution mode in the class JavaDoc, which should also be updated.
##########
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java:
##########
@@ -913,6 +920,18 @@ public LinkedHashSet<Class<?>> getRegisteredPojoTypes() {
return registeredPojoTypes;
}
+ /**
+ * Get if the auto type registration is disabled.
+ *
+ * @return if the auto type registration is disabled.
+ * @deprecated All Flink DataSet APIs are deprecated since Flink 1.18 and will be removed in a
+ * future Flink major version. You can still build your application in DataSet, but you
+ * should move to either the DataStream and/or Table API.
+ * @see <a href="https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=158866741">
+ * FLIP-131: Consolidate the user-facing Dataflow SDKs/APIs (and deprecate the DataSet
+ * API</a>
+ */
+ @Deprecated
Review Comment:
We should also deprecated `disableAutoTypeRegistration`, and `AUTO_TYPE_REGISTRATION`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org