You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@fineract.apache.org by "airajena (via GitHub)" <gi...@apache.org> on 2026/02/03 14:38:55 UTC

Re: [PR] FINERACT-2050: Fix client transfer loan status transitioning to ACTIVE [fineract]

airajena commented on code in PR #5383:
URL: https://github.com/apache/fineract/pull/5383#discussion_r2759421820


##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/DefaultLoanLifecycleStateMachine.java:
##########
@@ -154,7 +154,8 @@ private LoanStatus getNextStatus(LoanEvent loanEvent, Loan loan) {
             break;
             case LOAN_CHARGE_PAYMENT:
             case LOAN_REPAYMENT_OR_WAIVER, LOAN_CHARGEBACK:
-                if (anyOfAllowedWhenComingFrom(from, LoanStatus.CLOSED_OBLIGATIONS_MET, LoanStatus.OVERPAID)) {
+                if (anyOfAllowedWhenComingFrom(from, LoanStatus.CLOSED_OBLIGATIONS_MET, LoanStatus.OVERPAID,

Review Comment:
   Yes,  I reviewed it, using LOAN_REPAYMENT_OR_WAIVER / LOAN_OVERPAYMENT to drive the transfer completion transition is semantically wrong, so I fixed it properly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org