[GitHub] [iceberg] rdblue commented on pull request #6252: push down min/max/count to iceberg

[GitBox <gi...@apache.org>]

rdblue commented on PR #6252:
URL: https://github.com/apache/iceberg/pull/6252#issuecomment-1345704862

   @huaxingao, as I looked at this, the main thing that I think we should change is moving most of the logic into core or API so that it can be reused across query engines. I tried to do that and opened a PR for it here: https://github.com/apache/iceberg/pull/6405
   
   Please take a look!
   
   That creates a public `AggregateEvaluator` that produces the aggregate row type and a row of aggregated values. If anything is missing, the values are `null`. I think this could be cleanly wrapped in Spark. What do you think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org