You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/09/27 00:52:55 UTC

[GitHub] [incubator-pinot] Jackie-Jiang edited a comment on issue #4585: Presence vector

Jackie-Jiang edited a comment on issue #4585: Presence vector
URL: https://github.com/apache/incubator-pinot/pull/4585#issuecomment-535738280
 
 
   The record reader you mentioned is for ingesting data into real-time. When we convert real-time segment into offline segment, we use the RealtimeSegmentConverter which does not perform any transform on the records as records should already be in the desired format.
   The concern is more about module isolation, meaning SegmentCreator interface should not expect the GenericRow to have a field of bitmap.
   > 
   > We considered this option. However, the problem is that it's extremely difficult to identify default null value which is outside the domain of legitimate values. In many cases there could be an overlap.
   
   I don't quite follow. The logic should be very straight forward. If we allow null value, put the null value into the presence vector; if not, throw exception
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org