You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/05/17 17:09:04 UTC

[GitHub] [spark] cloud-fan commented on a change in pull request #32574: [SPARK-35427][SQL][TESTS] Check the `EXCEPTION` rebase mode for Avro/Parquet

cloud-fan commented on a change in pull request #32574:
URL: https://github.com/apache/spark/pull/32574#discussion_r633709354



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRebaseDatetimeSuite.scala
##########
@@ -374,6 +375,58 @@ abstract class ParquetRebaseDatetimeSuite
       }
     }
   }
+
+  test("SPARK-35427: datetime rebasing in the EXCEPTION mode") {

Review comment:
       do we need to clean up the existing tests to remove code that are being tested here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org