[jira] Closed: (MPANT-13) pom.build.unitTest.resources.includes is illegal

[ji...@codehaus.org]

Message:

   The following issue has been closed.

---------------------------------------------------------------------
View the issue:
  http://jira.codehaus.org/secure/ViewIssue.jspa?key=MPANT-13

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: MPANT-13
    Summary: pom.build.unitTest.resources.includes is illegal
       Type: Bug

     Status: Closed
   Priority: Major
 Resolution: FIXED

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

    Project: maven-ant-plugin
   Fix Fors:
             1.7
   Versions:
             1.6
             1.7

   Assignee: Arnaud HERITIER
   Reporter: Matthias Kerkhoff

    Created: Wed, 28 Apr 2004 3:17 PM
    Updated: Thu, 29 Apr 2004 1:06 AM
Environment: any

Description:
build.jelly, line 246 (as of 27/04/2004 )  contains the
following code block:

      <j:choose trim="true">
        <j:when test="${!pom.build.unitTest.resources.includes.isEmpty()}">
           <j:set var="maven.has.test.resource.patterns" value="true"/>
         </j:when>
         <j:when test="${!pom.build.unitTest.resources.excludes.isEmpty()}">
           <j:set var="maven.has.test.resource.patterns" value="true"/>
         </j:when>
      </j:choose>

      <j:if test="${maven.has.test.resource.patterns}">
 
      <copy todir="$${testclassesdir}">
        <fileset dir="${pom.build.unitTestSourceDirectory}">
          <j:forEach var="res" items="${pom.build.unitTest.resources.includes}">
            <include name="${res}"/>
          </j:forEach>
          <j:forEach var="res" items="${pom.build.unitTest.resources.excludes}">
            <exclude name="${res}"/>
          </j:forEach>
        </fileset>
      </copy>
      </j:if>

According to the schema definition, there can not be a
 build.unitTest.resources.includes
element. Actually, there is an intermediate <resource> 
level. 

The above mentioned block causes jelly exceptions in 
(at least) rc2 and the current snapshots. 
A symptom of this bug is that "maven dist" will fail 
to build a source distribution".

A proper solution would be to add a nested iteration over 
all <resources>/<resouce> elements. We have choosen to
<j:if>def the block pasted above, which gives as a working
"maven dist" too.



---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org