[GitHub] [iceberg] rdblue commented on a diff in pull request #4772: Core: Add request headers to REST client

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #4772:
URL: https://github.com/apache/iceberg/pull/4772#discussion_r873218479


##########
core/src/main/java/org/apache/iceberg/rest/HTTPClient.java:
##########
@@ -59,13 +59,12 @@ public class HTTPClient implements RESTClient {
   private final String uri;
   private final CloseableHttpClient httpClient;
   private final ObjectMapper mapper;
-  private final Map<String, String> additionalHeaders;
+  private final Map<String, String> baseHeaders;
 
-  private HTTPClient(
-      String uri, CloseableHttpClient httpClient, Map<String, String> additionalHeaders) {
+  private HTTPClient(String uri, Map<String, String> baseHeaders) {
     this.uri = uri;
-    this.httpClient = httpClient != null ? httpClient : HttpClients.createDefault();

Review Comment:
   The builder was never initializing `httpClient` so it was always null anyway. This removes the unnecessary argument. FYI @kbendick.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org