[GitHub] [trafficcontrol] mattjackson220 opened a new pull request #3647: Fix for missing port in redirect to https

[GitBox <gi...@apache.org>]

mattjackson220 opened a new pull request #3647: Fix for missing port in redirect to https
URL: https://github.com/apache/trafficcontrol/pull/3647
 
 
   ## What does this PR (Pull Request) do?
   Fixes a bug in the TM HTTPS code that was preventing redirects from working between the HTTP endpoint and the new HTTPS endpoint.
   
   - [X] This PR is not related to any Issue 
   
   
   ## Which Traffic Control components are affected by this PR?
   - Traffic Monitor
   - Traffic Router
   No documentation because it is a minor fix and the big change has already been documented
   No tests included for same reason
   
   ## What is the best way to verify this PR?
   In CDN In A Box, update the TM run script with these properties:
   "httpsListener": ":443",
   "certFile": "/shared/ssl/infra.ciab.test.crt",
   "keyFile": "/shared/ssl/infra.ciab.test.key"
   
   Verify that the TM HTTP endpoint redirects to the HTTPS endpoint and the the HTTPS endpoint shows the expected information.  Verify that Traffic Router successfully gets the configuration from TM through the redirect.  Verify that Traffic Stats successfully calls TM through redirect.
   
   
   - [X] This PR includes tests OR I have explained why tests are unnecessary
   - [X] This PR includes documentation OR I have explained why documentation is unnecessary
   - [X] This PR includes an update to CHANGELOG.md OR such an update is not necessary
   - [X] This PR includes any and all required license headers
   - [X] This PR ensures that database migration sequence is correct OR this PR does not include a database migration
   - [X] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
   
   <!--
   Licensed to the Apache Software Foundation (ASF) under one
   or more contributor license agreements.  See the NOTICE file
   distributed with this work for additional information
   regarding copyright ownership.  The ASF licenses this file
   to you under the Apache License, Version 2.0 (the
   "License"); you may not use this file except in compliance
   with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
   Unless required by applicable law or agreed to in writing,
   software distributed under the License is distributed on an
   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
   KIND, either express or implied.  See the License for the
   specific language governing permissions and limitations
   under the License.
   -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services