You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Sian January (JIRA)" <ji...@apache.org> on 2006/12/08 16:14:21 UTC
[jira] Created: (HARMONY-2556) [classlib] [luni] Fixes for some
minor issues in the java.lang and java.io packages found by Melody
[classlib] [luni] Fixes for some minor issues in the java.lang and java.io packages found by Melody
---------------------------------------------------------------------------------------------------
Key: HARMONY-2556
URL: http://issues.apache.org/jira/browse/HARMONY-2556
Project: Harmony
Issue Type: Bug
Reporter: Sian January
Priority: Minor
As summary.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-2556) [classlib] [luni] Fixes for some
minor issues in the java.lang and java.io packages found by Melody
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2556?page=all ]
Tim Ellison closed HARMONY-2556.
--------------------------------
Resolution: Fixed
Marking as fixed. Verified by Sian.
SecurityManager issue being tracked separately.
> [classlib] [luni] Fixes for some minor issues in the java.lang and java.io packages found by Melody
> ---------------------------------------------------------------------------------------------------
>
> Key: HARMONY-2556
> URL: http://issues.apache.org/jira/browse/HARMONY-2556
> Project: Harmony
> Issue Type: Bug
> Reporter: Sian January
> Assigned To: Tim Ellison
> Priority: Minor
> Attachments: exclusionFilter_patch.txt, java.io_patch.txt, java.io_patch2.txt, java.lang_patch.txt
>
>
> As summary.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-2556) [classlib] [luni] Fixes for some
minor issues in the java.lang and java.io packages found by Melody
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2556?page=all ]
Tim Ellison reassigned HARMONY-2556:
------------------------------------
Assignee: Tim Ellison
> [classlib] [luni] Fixes for some minor issues in the java.lang and java.io packages found by Melody
> ---------------------------------------------------------------------------------------------------
>
> Key: HARMONY-2556
> URL: http://issues.apache.org/jira/browse/HARMONY-2556
> Project: Harmony
> Issue Type: Bug
> Reporter: Sian January
> Assigned To: Tim Ellison
> Priority: Minor
> Attachments: exclusionFilter_patch.txt, java.io_patch.txt, java.lang_patch.txt
>
>
> As summary.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-2556) [classlib] [luni] Fixes for some
minor issues in the java.lang and java.io packages found by Melody
Posted by "Sian January (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2556?page=all ]
Sian January updated HARMONY-2556:
----------------------------------
Patch Info: [Patch Available]
> [classlib] [luni] Fixes for some minor issues in the java.lang and java.io packages found by Melody
> ---------------------------------------------------------------------------------------------------
>
> Key: HARMONY-2556
> URL: http://issues.apache.org/jira/browse/HARMONY-2556
> Project: Harmony
> Issue Type: Bug
> Reporter: Sian January
> Priority: Minor
> Attachments: java.io_patch.txt, java.lang_patch.txt
>
>
> As summary.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-2556) [classlib] [luni] Fixes for some
minor issues in the java.lang and java.io packages found by Melody
Posted by "Sian January (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2556?page=comments#action_12457821 ]
Sian January commented on HARMONY-2556:
---------------------------------------
java.io_patch2.txt was applied as expected. It looks like the issues in SecurityManager are being tracked by HARMONY-2301 even though it's not resolved yet, so I'm happy for this bug to be closed now unless Tim or Alexey feel differently.
> [classlib] [luni] Fixes for some minor issues in the java.lang and java.io packages found by Melody
> ---------------------------------------------------------------------------------------------------
>
> Key: HARMONY-2556
> URL: http://issues.apache.org/jira/browse/HARMONY-2556
> Project: Harmony
> Issue Type: Bug
> Reporter: Sian January
> Assigned To: Tim Ellison
> Priority: Minor
> Attachments: exclusionFilter_patch.txt, java.io_patch.txt, java.io_patch2.txt, java.lang_patch.txt
>
>
> As summary.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-2556) [classlib] [luni] Fixes for some
minor issues in the java.lang and java.io packages found by Melody
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2556?page=comments#action_12457426 ]
Tim Ellison commented on HARMONY-2556:
--------------------------------------
Exclusion list looks ok -- committed patch at repo revision r485774.
> [classlib] [luni] Fixes for some minor issues in the java.lang and java.io packages found by Melody
> ---------------------------------------------------------------------------------------------------
>
> Key: HARMONY-2556
> URL: http://issues.apache.org/jira/browse/HARMONY-2556
> Project: Harmony
> Issue Type: Bug
> Reporter: Sian January
> Assigned To: Tim Ellison
> Priority: Minor
> Attachments: exclusionFilter_patch.txt, java.io_patch.txt, java.lang_patch.txt
>
>
> As summary.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-2556) [classlib] [luni] Fixes for some
minor issues in the java.lang and java.io packages found by Melody
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2556?page=comments#action_12457599 ]
Alexey Varlamov commented on HARMONY-2556:
------------------------------------------
The only side effect I can think of is NPE thrown on that redundant call to String.length() - i.e. this is tricky way to validate input arg. I did not check this though.
Regarding SecurityManager, the code is still incorrect - see HARMONY 2301. It's a pity I did not commit it early, need to adjust the patch now.
> [classlib] [luni] Fixes for some minor issues in the java.lang and java.io packages found by Melody
> ---------------------------------------------------------------------------------------------------
>
> Key: HARMONY-2556
> URL: http://issues.apache.org/jira/browse/HARMONY-2556
> Project: Harmony
> Issue Type: Bug
> Reporter: Sian January
> Assigned To: Tim Ellison
> Priority: Minor
> Attachments: exclusionFilter_patch.txt, java.io_patch.txt, java.lang_patch.txt
>
>
> As summary.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-2556) [classlib] [luni] Fixes for some
minor issues in the java.lang and java.io packages found by Melody
Posted by "Sian January (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2556?page=all ]
Sian January updated HARMONY-2556:
----------------------------------
Attachment: java.io_patch2.txt
Sorry about those test failures - I did run the tests, but I don't think I noticed them because there were some other failures in another package... Alexey is right that the side effect required was a NullPointerException, but I think it would be clearer to actually throw the Exception, so I'm attaching a patch that does that instead. (java.io_patch2.txt)
Also my java.lang patch removed an unused import from the String class as well as the obsolete SecurityManager changes so if you have time to commit that too that would be great.
> [classlib] [luni] Fixes for some minor issues in the java.lang and java.io packages found by Melody
> ---------------------------------------------------------------------------------------------------
>
> Key: HARMONY-2556
> URL: http://issues.apache.org/jira/browse/HARMONY-2556
> Project: Harmony
> Issue Type: Bug
> Reporter: Sian January
> Assigned To: Tim Ellison
> Priority: Minor
> Attachments: exclusionFilter_patch.txt, java.io_patch.txt, java.io_patch2.txt, java.lang_patch.txt
>
>
> As summary.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-2556) [classlib] [luni] Fixes for some
minor issues in the java.lang and java.io packages found by Melody
Posted by "Sian January (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2556?page=all ]
Sian January updated HARMONY-2556:
----------------------------------
Attachment: java.lang_patch.txt
java.io_patch.txt
I have attached two patches - one for the java.lang package and one for the java.io package to fix bugs found by Melody. I'm happy to break down the patches into individual fixes for a reviewer, or explain any of the changes if they are non-obvious.
> [classlib] [luni] Fixes for some minor issues in the java.lang and java.io packages found by Melody
> ---------------------------------------------------------------------------------------------------
>
> Key: HARMONY-2556
> URL: http://issues.apache.org/jira/browse/HARMONY-2556
> Project: Harmony
> Issue Type: Bug
> Reporter: Sian January
> Priority: Minor
> Attachments: java.io_patch.txt, java.lang_patch.txt
>
>
> As summary.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-2556) [classlib] [luni] Fixes for some
minor issues in the java.lang and java.io packages found by Melody
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2556?page=comments#action_12457425 ]
Tim Ellison commented on HARMONY-2556:
--------------------------------------
Sian,
- The java_lang_patch is now obsolete based on changes already applied to the SecurityManager
- The java_io_patch was applied except the 'redundant' calls to String.length() which cause test failues if removed. I've not looked closely enough to figure it out, but presumably there are side-effects that are relied upon.
The changes were made to the LUNI module at repo revision r485770.
> [classlib] [luni] Fixes for some minor issues in the java.lang and java.io packages found by Melody
> ---------------------------------------------------------------------------------------------------
>
> Key: HARMONY-2556
> URL: http://issues.apache.org/jira/browse/HARMONY-2556
> Project: Harmony
> Issue Type: Bug
> Reporter: Sian January
> Assigned To: Tim Ellison
> Priority: Minor
> Attachments: exclusionFilter_patch.txt, java.io_patch.txt, java.lang_patch.txt
>
>
> As summary.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-2556) [classlib] [luni] Fixes for some
minor issues in the java.lang and java.io packages found by Melody
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2556?page=comments#action_12457663 ]
Tim Ellison commented on HARMONY-2556:
--------------------------------------
The null pointer check (in java.io_patch2.txt) was applied in repository revision r486090.
The String import of PatternSyntaxException is used, albeit only in the JavaDoc for public boolean matches(String).
Now I don't see that any changes are required in SecurityManager. Alexey: can you clarify your comment? Do you think any further changes are required?
> [classlib] [luni] Fixes for some minor issues in the java.lang and java.io packages found by Melody
> ---------------------------------------------------------------------------------------------------
>
> Key: HARMONY-2556
> URL: http://issues.apache.org/jira/browse/HARMONY-2556
> Project: Harmony
> Issue Type: Bug
> Reporter: Sian January
> Assigned To: Tim Ellison
> Priority: Minor
> Attachments: exclusionFilter_patch.txt, java.io_patch.txt, java.io_patch2.txt, java.lang_patch.txt
>
>
> As summary.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-2556) [classlib] [luni] Fixes for some
minor issues in the java.lang and java.io packages found by Melody
Posted by "Sian January (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2556?page=all ]
Sian January updated HARMONY-2556:
----------------------------------
Attachment: exclusionFilter_patch.txt
Attached a patch (exclusionFilter_patch.txt) for the FindBugs exclusion filter file (standard/tools/FindBugs/exclusionFilter.xml) that excludes some false positives found in the java.lang and java.io packages.
> [classlib] [luni] Fixes for some minor issues in the java.lang and java.io packages found by Melody
> ---------------------------------------------------------------------------------------------------
>
> Key: HARMONY-2556
> URL: http://issues.apache.org/jira/browse/HARMONY-2556
> Project: Harmony
> Issue Type: Bug
> Reporter: Sian January
> Priority: Minor
> Attachments: exclusionFilter_patch.txt, java.io_patch.txt, java.lang_patch.txt
>
>
> As summary.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira