[GitHub] [iceberg] ajantha-bhat commented on a diff in pull request #6573: Docs: Add information on how to read from branches and tags in Spark docs

[GitBox <gi...@apache.org>]

ajantha-bhat commented on code in PR #6573:
URL: https://github.com/apache/iceberg/pull/6573#discussion_r1069020854


##########
docs/spark-queries.md:
##########
@@ -126,6 +126,8 @@ To select a specific table snapshot or the snapshot at some time in the DataFram
 

Review Comment:
   we need to change two to four.



##########
docs/spark-queries.md:
##########
@@ -126,6 +126,8 @@ To select a specific table snapshot or the snapshot at some time in the DataFram
 
 * `snapshot-id` selects a specific table snapshot
 * `as-of-timestamp` selects the current snapshot at a timestamp, in milliseconds
+* `branch` selects the head snapshot of the specified branch. Note that currently branch cannot be combined with as-of-timestamp.
+* `tag` selects the snapshot associated with the specified tag

Review Comment:
   do we need to mention that tag also cannot be combined with as-of-timestamp.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org