You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by ab...@apache.org on 2017/01/02 10:18:32 UTC
[11/19] lucene-solr:jira/solr-9854: SOLR-9843 Fix up
DocValuesNotIndexedTest failures (cherry picked from commit f6a3557)
SOLR-9843 Fix up DocValuesNotIndexedTest failures
(cherry picked from commit f6a3557)
Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/3ccd15a7
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/3ccd15a7
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/3ccd15a7
Branch: refs/heads/jira/solr-9854
Commit: 3ccd15a7658ad2821e8a2d2916781265db6f3afe
Parents: cb266d5
Author: Erick Erickson <er...@apache.org>
Authored: Thu Dec 29 18:10:34 2016 -0800
Committer: Erick Erickson <er...@apache.org>
Committed: Thu Dec 29 18:14:39 2016 -0800
----------------------------------------------------------------------
.../org/apache/solr/cloud/DocValuesNotIndexedTest.java | 10 ----------
1 file changed, 10 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/3ccd15a7/solr/core/src/test/org/apache/solr/cloud/DocValuesNotIndexedTest.java
----------------------------------------------------------------------
diff --git a/solr/core/src/test/org/apache/solr/cloud/DocValuesNotIndexedTest.java b/solr/core/src/test/org/apache/solr/cloud/DocValuesNotIndexedTest.java
index f5257f8..be9f9a3 100644
--- a/solr/core/src/test/org/apache/solr/cloud/DocValuesNotIndexedTest.java
+++ b/solr/core/src/test/org/apache/solr/cloud/DocValuesNotIndexedTest.java
@@ -256,10 +256,6 @@ public class DocValuesNotIndexedTest extends SolrCloudTestCase {
solrQuery.addSort("id", SolrQuery.ORDER.asc);
final QueryResponse rsp = client.query(COLLECTION, solrQuery);
SolrDocumentList res = rsp.getResults();
- //TODO remove after SOLR-9843
- if (order.length != res.getNumFound()) {
- log.error("(3) About to fail, response is: " + rsp.toString());
- }
assertEquals("Should have exactly " + order.length + " documents returned", order.length, res.getNumFound());
String expected;
for (int idx = 0; idx < res.size(); ++idx) {
@@ -305,10 +301,6 @@ public class DocValuesNotIndexedTest extends SolrCloudTestCase {
if (prop.getName().startsWith("bool")) expected = 3; //true, false and null
List<Group> fieldCommandGroups = fieldCommand.getValues();
- //TODO: remove me since this is excessive in the normal case, this is in for SOLR-9843
- if (expected != fieldCommandGroups.size()) {
- log.error("(1) About to fail assert, response is: " + rsp.toString());
- }
assertEquals("Did not find the expected number of groups for field " + prop.getName(), expected, fieldCommandGroups.size());
}
}
@@ -381,8 +373,6 @@ public class DocValuesNotIndexedTest extends SolrCloudTestCase {
break;
default:
- //TODO remove me after SOLR-9843
- log.error("(2) About to fail, response is: " + rsp.toString());
fail("Unexpected number of elements in the group for " + prop.getName() + ": " + grp.getResult().size());
}
}