You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/10/28 13:57:44 UTC

[GitHub] [flink] GJL commented on a change in pull request #9920: [FLINK-14389][runtime] Restore task state before restarting tasks in DefaultScheduler

GJL commented on a change in pull request #9920: [FLINK-14389][runtime] Restore task state before restarting tasks in DefaultScheduler
URL: https://github.com/apache/flink/pull/9920#discussion_r339576356
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultScheduler.java
 ##########
 @@ -212,6 +212,13 @@ private Runnable restartTasks(final Set<ExecutionVertexVersion> executionVertexV
 
 			resetForNewExecutionIfInTerminalState(verticesToRestart);
 
+			try {
+				restoreState(verticesToRestart);
 
 Review comment:
   Does it make sense to move this block into `resetForNewExecutionIfInTerminalState()`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services