You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "deardeng (via GitHub)" <gi...@apache.org> on 2026/02/09 13:13:51 UTC

[PR] [fix](cloud) Fix misleading CommittedVersion display in show partitions [doris]

deardeng opened a new pull request, #60623:
URL: https://github.com/apache/doris/pull/60623

   In cloud mode, CloudPartition sets nextVersion to -1 (unknown), but getCommittedVersion() inherited from Partition computes nextVersion - 1 which returns -2, a confusing value for users. Override getCommittedVersion() in CloudPartition to return -1 directly, consistent with the "unknown/managed by meta-service" semantics.
   
   ### What problem does this PR solve?
   
   Issue Number: close #xxx
   
   Related PR: #xxx
   
   Problem Summary:
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Test <!-- At least one of them must be included. -->
       - [ ] Regression test
       - [x] Unit Test
       - [ ] Manual test (add detailed scripts or steps below)
       - [ ] No need to test or manual test. Explain why:
           - [ ] This is a refactor/code format and no logic has been changed.
           - [ ] Previous test can cover this change.
           - [ ] No code files have been changed.
           - [ ] Other reason <!-- Add your reason?  -->
   
   - Behavior changed:
       - [x] No.
       - [ ] Yes. <!-- Explain the behavior change -->
   
   - Does this need documentation?
       - [x] No.
       - [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
   
   ### Check List (For Reviewer who merge this PR)
   
   - [ ] Confirm the release note
   - [ ] Confirm test cases
   - [ ] Confirm document
   - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](cloud) Fix misleading CommittedVersion display in show partitions [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #60623:
URL: https://github.com/apache/doris/pull/60623#issuecomment-3876739058

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](cloud) Fix misleading CommittedVersion display in show partitions [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60623:
URL: https://github.com/apache/doris/pull/60623#issuecomment-3871883921

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 28.63 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit c8ce76b9ea3653f4ca2a7b349ca2d7fee4206138, data reload: false
   
   query1	0.05	0.04	0.05
   query2	0.09	0.04	0.05
   query3	0.25	0.08	0.07
   query4	1.62	0.12	0.12
   query5	0.26	0.25	0.24
   query6	1.17	0.69	0.68
   query7	0.03	0.02	0.03
   query8	0.05	0.04	0.04
   query9	0.55	0.50	0.48
   query10	0.56	0.54	0.54
   query11	0.14	0.10	0.10
   query12	0.14	0.10	0.11
   query13	0.64	0.61	0.61
   query14	1.06	1.06	1.06
   query15	0.89	0.86	0.88
   query16	0.40	0.39	0.39
   query17	1.15	1.16	1.08
   query18	0.23	0.22	0.21
   query19	2.07	2.04	2.05
   query20	0.02	0.02	0.02
   query21	15.40	0.29	0.16
   query22	5.34	0.06	0.05
   query23	16.29	0.28	0.11
   query24	0.96	0.46	0.84
   query25	0.10	0.06	0.18
   query26	0.15	0.13	0.13
   query27	0.08	0.06	0.06
   query28	4.63	1.14	0.97
   query29	12.59	3.99	3.23
   query30	0.28	0.16	0.12
   query31	2.81	0.64	0.40
   query32	3.23	0.59	0.50
   query33	3.19	3.26	3.22
   query34	16.16	5.39	4.76
   query35	4.84	4.80	4.83
   query36	0.64	0.50	0.49
   query37	0.11	0.07	0.08
   query38	0.09	0.05	0.04
   query39	0.05	0.03	0.03
   query40	0.20	0.17	0.15
   query41	0.09	0.04	0.03
   query42	0.04	0.03	0.02
   query43	0.04	0.04	0.03
   Total cold run time: 98.68 s
   Total hot run time: 28.63 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](cloud) Fix misleading CommittedVersion display in show partitions [doris]

Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #60623:
URL: https://github.com/apache/doris/pull/60623#issuecomment-3871634641

   
   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
   
   Please clearly describe your PR:
   1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
   2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
   3. What features were added. Why was this function added?
   4. Which code was refactored and why was this part of the code refactored?
   5. Which functions were optimized and what is the difference before and after the optimization?
       


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](cloud) Fix misleading CommittedVersion display in show partitions [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen merged PR #60623:
URL: https://github.com/apache/doris/pull/60623


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](cloud) Fix misleading CommittedVersion display in show partitions [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60623:
URL: https://github.com/apache/doris/pull/60623#issuecomment-3871781019

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 30144 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit c8ce76b9ea3653f4ca2a7b349ca2d7fee4206138, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17597	4542	4298	4298
   q2	2092	355	234	234
   q3	10130	1364	732	732
   q4	10197	770	328	328
   q5	7524	2231	1911	1911
   q6	198	176	147	147
   q7	883	740	611	611
   q8	9293	1390	1133	1133
   q9	4683	4603	4592	4592
   q10	6785	1964	1550	1550
   q11	536	300	303	300
   q12	338	380	227	227
   q13	17759	4084	3204	3204
   q14	243	233	225	225
   q15	898	823	802	802
   q16	677	685	619	619
   q17	708	873	492	492
   q18	6409	5703	5648	5648
   q19	1246	993	619	619
   q20	494	496	381	381
   q21	2562	1812	1895	1812
   q22	362	315	279	279
   Total cold run time: 101614 ms
   Total hot run time: 30144 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4340	4326	4352	4326
   q2	259	370	245	245
   q3	2091	2655	2211	2211
   q4	1351	1729	1300	1300
   q5	4298	4183	4280	4183
   q6	221	180	139	139
   q7	1826	1797	1655	1655
   q8	2470	2680	2485	2485
   q9	7560	7471	7529	7471
   q10	2838	3112	2673	2673
   q11	546	483	522	483
   q12	797	742	617	617
   q13	3800	4475	3591	3591
   q14	305	305	284	284
   q15	894	814	794	794
   q16	662	709	672	672
   q17	1136	1409	1615	1409
   q18	8131	7865	8167	7865
   q19	961	917	939	917
   q20	2093	2126	1991	1991
   q21	4931	4465	4449	4449
   q22	617	585	521	521
   Total cold run time: 52127 ms
   Total hot run time: 50281 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](cloud) Fix misleading CommittedVersion display in show partitions [doris]

Posted by "deardeng (via GitHub)" <gi...@apache.org>.
deardeng commented on PR #60623:
URL: https://github.com/apache/doris/pull/60623#issuecomment-3871634789

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](cloud) Fix misleading CommittedVersion display in show partitions [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60623:
URL: https://github.com/apache/doris/pull/60623#issuecomment-3872019776

   # FE UT Coverage Report
   Increment line coverage `  100.00% (1/1)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60623_c8ce76b9ea3653f4ca2a7b349ca2d7fee4206138/fe_increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60623_c8ce76b9ea3653f4ca2a7b349ca2d7fee4206138/fe_report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](cloud) Fix misleading CommittedVersion display in show partitions [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #60623:
URL: https://github.com/apache/doris/pull/60623#issuecomment-3876739355

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](cloud) Fix misleading CommittedVersion display in show partitions [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60623:
URL: https://github.com/apache/doris/pull/60623#issuecomment-3875324181

   # FE Regression Coverage Report
   Increment line coverage `  100.00% (1/1)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60623_c8ce76b9ea3653f4ca2a7b349ca2d7fee4206138_merge_fe/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60623_c8ce76b9ea3653f4ca2a7b349ca2d7fee4206138_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](cloud) Fix misleading CommittedVersion display in show partitions [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60623:
URL: https://github.com/apache/doris/pull/60623#issuecomment-3872712176

   # FE Regression Coverage Report
   Increment line coverage `  100.00% (1/1)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60623_c8ce76b9ea3653f4ca2a7b349ca2d7fee4206138_merge_fe/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60623_c8ce76b9ea3653f4ca2a7b349ca2d7fee4206138_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org