[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct
URL: https://github.com/apache/incubator-pinot/pull/4216#discussion_r285257300
 
 

 ##########
 File path: pinot-common/src/thrift/query.thrift
 ##########
 @@ -0,0 +1,76 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+namespace java org.apache.pinot.common.request
+
+struct DataSource {
+  1: optional string tableName;
+}
+
+struct PinotQuery {
+  1: optional i32 version;
+  2: optional DataSource dataSource;
+  3: optional list<Expression> selectList;
+  4: optional Expression filterExpression;
+  5: optional list<Expression> groupByList;
+  6: optional list<Expression> orderByList;
+  7: optional Expression havingExpression;
+  8: optional i32 limit = 10;
+  9: optional i32 offset = 0;
+  10: optional map<string, string> debugOptions;
+  11: optional map<string, string> queryOptions;
+}
+
+struct InstanceRequestV2 {
+  1: required i64 requestId;
+  3: optional list<string> searchSegments;
+  4: optional bool enableTrace;
+  5: optional string brokerId;
+}
+
+enum ExpressionType {
+  LITERAL,
+  IDENTIFIER,
+  FUNCTION
+}
+
+struct Expression {
+  1: required ExpressionType type;
+  2: optional Function functionCall;
+  3: optional Literal literal;
+  4: optional Identifier identifier;
+}
+
+struct Identifier {
+  1: required string name;
+}
+
+union Literal {
+  1: optional bool boolValue;
+  2: optional byte byteValue;
+  3: optional i32 intValue;
 
 Review comment:
   i16 shortValue?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org