[jira] [Commented] (KARAF-4701) Problem installing feature

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KARAF-4701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15940135#comment-15940135 ] 

ASF GitHub Bot commented on KARAF-4701:
---------------------------------------

GitHub user vladimirfx opened a pull request:

    https://github.com/apache/karaf/pull/291

    [KARAF-4701] forcing deterministic heuristic of capbillities comparison for Subsystem Resolver

    When some bundle exactly duplicated in two or more installing features Felix Resolver may randomly chose one that not already installed. 
    Karaf already use some hack for deterministic resolution in CandidateComparator. But as now it can't produce stable result for absolutly identical bundles.
    This patch expand deterministic resolution hack to use Requirement identity in comparison, ie compare from witch feature/subsystem/region bundle is coming.
    Steps to reproduce described in bug report. All version from 4.0.6 up to current master is affected. But with Felix Resolver 1.12.0 it is harder to reproduce.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cit-consulting/karaf KARAF-4701

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/karaf/pull/291.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #291
    
----
commit 847ea3366093d463c13e5796363f9a5231af2fdc
Author: Vladimir Konkov <vk...@citc.ru>
Date:   2017-03-24T09:50:23Z

    [KARAF-4701] forcing deterministic heuristic of capbillities comparison for Subsystem Resolver

----


> Problem installing feature
> --------------------------
>
>                 Key: KARAF-4701
>                 URL: https://issues.apache.org/jira/browse/KARAF-4701
>             Project: Karaf
>          Issue Type: Bug
>          Components: karaf-feature
>    Affects Versions: 4.0.6
>            Reporter: Hannes Bjurek
>
> Sometimes(roughly every 5) time we deploy a feature karaf thinks it needs to refresh our org.apache.servicemix.bundles.jaxb-impl bundle even though it should not. We have debugged the Deployer.computeDeployent method and discovered that cause of this problem is that the jaxb-impl bundle is duplicated in the bundlesPerRegions-map and then it gets duplicated in the toDeploy list.
> The "first" jaxb-impl gets removed on line 1219 but the "second" one of course is still there and then it triggers the unexpected event.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)