You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@yunikorn.apache.org by "Wei Huang (Jira)" <ji...@apache.org> on 2023/09/30 00:49:00 UTC
[jira] [Comment Edited] (YUNIKORN-2009) Placeholder pods should be created with limits
[ https://issues.apache.org/jira/browse/YUNIKORN-2009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770588#comment-17770588 ]
Wei Huang edited comment on YUNIKORN-2009 at 9/30/23 12:48 AM:
---------------------------------------------------------------
-oh, this is fixed in YUNIKORN-1908 last month.-
-Close it.-
was (Author: JIRAUSER299807):
oh, this is fixed in YUNIKORN-1908 last month.
Close it.
> Placeholder pods should be created with limits
> ----------------------------------------------
>
> Key: YUNIKORN-2009
> URL: https://issues.apache.org/jira/browse/YUNIKORN-2009
> Project: Apache YuniKorn
> Issue Type: Improvement
> Components: shim - kubernetes
> Reporter: Wei Huang
> Assignee: Wei Huang
> Priority: Major
> Labels: pull-request-available
>
> In some k8s env, namespace is enabled with {*}{{LimitRange}}{*}:
> {code:java}
> apiVersion: v1
> kind: LimitRange
> metadata:
> name: default
> spec:
> limits:
> - default:
> cpu: 100m
> ephemeral-storage: 10Gi
> memory: 128Mi
> defaultRequest:
> cpu: 100m
> ephemeral-storage: 1Gi
> memory: 128Mi
> type: Container{code}
> However, shim code spawns placeholder pods with requests only, which cause the placeholder pods rejected by API server, and hence the whole Job gets into pending:
> {code:java}
> 2023-09-29T13:19:17.851-0700 ERROR cache/placeholder_manager.go:99 failed to create placeholder pod {"error": "Pod \"tg-foo-task-group-foo-gang-0\" is invalid: spec.containers[0].resources.requests: Invalid value: \"1\": must be less than or equal to cpu limit"}{code}
> I'd propose setting the same amount of request to the placeholder Pod's limits, so system's LimitRange won't auto-set lower limits value.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org