You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "naruto-lgtm (via GitHub)" <gi...@apache.org> on 2026/06/20 07:19:53 UTC

Re: [PR] Correctly quote remaining identifiers in single path segments in TaskSDK client [airflow]

naruto-lgtm commented on PR #68617:
URL: https://github.com/apache/airflow/pull/68617#issuecomment-4756837175

   Yeah, this fixes that one. Under the old f-string `Variable.get("/foo/bar")` went out as `variables//foo/bar`, and httpx's own URL normalization collapses that empty segment down to `variables/foo/bar` before the request even leaves the client, so the leading slash was silently dropped. With the quoting it goes as `variables/%2Ffoo%2Fbar`, which nothing collapses, and the server decodes `%2F` back to `/` after the route match, so the key arrives as `/foo/bar` intact.
   
   So the leading-slash case is genuinely fixed on the transport side. Anything still off for those keys would be downstream in the secrets-backend lookup rather than the URL construction.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org