Re: svn commit: r1644389 - in /jackrabbit/oak/trunk/oak-core/src: main/java/org/apache/jackrabbit/oak/plugins/segment/file/ main/java/org/apache/jackrabbit/oak/plugins/segment/file/tooling/ test/java/org/apache/jackrabbit/oak/plugins/segment/file/

[Julian Reschke <ju...@gmx.de>]

On 2014-12-10 14:10, mduerig@apache.org wrote:
> Author: mduerig
> Date: Wed Dec 10 13:10:30 2014
> New Revision: 1644389
>
> URL: http://svn.apache.org/r1644389
> Log:
> OAK-2333: SegmentMK startup slow with large journals
> Scan the journal.log backwards
>
> Modified:
>      jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/segment/file/FileStore.java
>      jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/segment/file/JournalReader.java
>      jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/segment/file/tooling/ConsistencyChecker.java
>      jackrabbit/oak/trunk/oak-core/src/test/java/org/apache/jackrabbit/oak/plugins/segment/file/JournalReaderTest.java
> ...

I now see failures in FileStoreBackupTest -- reproducibly on Windows:

> Tests in error:
>   testBackup(org.apache.jackrabbit.oak.plugins.backup.FileStoreBackupTest): The
> process cannot access the file because another process has locked a portion of t
> he file
>   testRestore(org.apache.jackrabbit.oak.plugins.backup.FileStoreBackupTest): The
>  process cannot access the file because another process has locked a portion of
> the file
>   testRestartAndGCWithoutMM(org.apache.jackrabbit.oak.plugins.segment.file.FileS
> toreTest): The process cannot access the file because another process has locked
>  a portion of the file
>   testRestartAndGCWithMM(org.apache.jackrabbit.oak.plugins.segment.file.FileStor
> eTest): The process cannot access the file because another process has locked a
> portion of the file
>   testCompaction(org.apache.jackrabbit.oak.plugins.segment.file.FileStoreTest):
> The process cannot access the file because another process has locked a portion
> of the file
>   testRecovery(org.apache.jackrabbit.oak.plugins.segment.file.FileStoreTest): Th
> e process cannot access the file because another process has locked a portion of
>  the file
>   segmentOverflow(org.apache.jackrabbit.oak.plugins.segment.file.FileStoreTest):
>  The process cannot access the file because another process has locked a portion
>  of the file



Maybe related to this change?

Best regards, Julian

Re: svn commit: r1644389 - in /jackrabbit/oak/trunk/oak-core/src: main/java/org/apache/jackrabbit/oak/plugins/segment/file/ main/java/org/apache/jackrabbit/oak/plugins/segment/file/tooling/ test/java/org/apache/jackrabbit/oak/plugins/segment/file/

[Michael Dürig <md...@apache.org>]

>> Could you try with the attached patch?
>>
>
> Looks good. First run passed.
>


Applied patch at http://svn.apache.org/r1644610.

Thanks for testing.

Michael

Re: svn commit: r1644389 - in /jackrabbit/oak/trunk/oak-core/src: main/java/org/apache/jackrabbit/oak/plugins/segment/file/ main/java/org/apache/jackrabbit/oak/plugins/segment/file/tooling/ test/java/org/apache/jackrabbit/oak/plugins/segment/file/

[Julian Reschke <ju...@gmx.de>]

On 2014-12-11 09:47, Michael Dürig wrote:
>
> Julian,
>
> Could you try with the attached patch?
>
> Michael

Looks good. First run passed.

Re: svn commit: r1644389 - in /jackrabbit/oak/trunk/oak-core/src: main/java/org/apache/jackrabbit/oak/plugins/segment/file/ main/java/org/apache/jackrabbit/oak/plugins/segment/file/tooling/ test/java/org/apache/jackrabbit/oak/plugins/segment/file/

[Michael Dürig <md...@apache.org>]

Julian,

Could you try with the attached patch?

Michael

On 10.12.14 11:40 , Julian Reschke wrote:
> On 2014-12-10 21:15, Michael Dürig wrote:
>>
>>
>> On 10.12.14 7:59 , Julian Reschke wrote:
>>>> segmentOverflow(org.apache.jackrabbit.oak.plugins.segment.file.FileStoreTest):
>>>>
>>>>
>>>>
>>>>  The process cannot access the file because another process has locked
>>>> a portion
>>>>  of the file
>>>
>>>
>>>
>>> Maybe related to this change?
>>
>> Probably yes. As I can't reproduce this, could you send a stack trace?
>>
>> Michael
>
> This one?
>

Re: svn commit: r1644389 - in /jackrabbit/oak/trunk/oak-core/src: main/java/org/apache/jackrabbit/oak/plugins/segment/file/ main/java/org/apache/jackrabbit/oak/plugins/segment/file/tooling/ test/java/org/apache/jackrabbit/oak/plugins/segment/file/

[Vikas Saurabh <vi...@gmail.com>]

>>
>> Probably yes. As I can't reproduce this, could you send a stack trace?
>>
>> Michael
>
I am seeing the same issue on my laptop while travis works fine. I
have win7 with me... while Travis, I guess, would be running some
container on linux.

Re: svn commit: r1644389 - in /jackrabbit/oak/trunk/oak-core/src: main/java/org/apache/jackrabbit/oak/plugins/segment/file/ main/java/org/apache/jackrabbit/oak/plugins/segment/file/tooling/ test/java/org/apache/jackrabbit/oak/plugins/segment/file/

[Julian Reschke <ju...@gmx.de>]

On 2014-12-10 21:15, Michael Dürig wrote:
>
>
> On 10.12.14 7:59 , Julian Reschke wrote:
>>> segmentOverflow(org.apache.jackrabbit.oak.plugins.segment.file.FileStoreTest):
>>>
>>>
>>>  The process cannot access the file because another process has locked
>>> a portion
>>>  of the file
>>
>>
>>
>> Maybe related to this change?
>
> Probably yes. As I can't reproduce this, could you send a stack trace?
>
> Michael

This one?

Re: svn commit: r1644389 - in /jackrabbit/oak/trunk/oak-core/src: main/java/org/apache/jackrabbit/oak/plugins/segment/file/ main/java/org/apache/jackrabbit/oak/plugins/segment/file/tooling/ test/java/org/apache/jackrabbit/oak/plugins/segment/file/

[Michael Dürig <md...@apache.org>]

On 10.12.14 7:59 , Julian Reschke wrote:
>> segmentOverflow(org.apache.jackrabbit.oak.plugins.segment.file.FileStoreTest):
>>
>>  The process cannot access the file because another process has locked
>> a portion
>>  of the file
>
>
>
> Maybe related to this change?

Probably yes. As I can't reproduce this, could you send a stack trace?

Michael