You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Jörn Kottmann (JIRA)" <ji...@apache.org> on 2010/01/06 14:11:15 UTC
[jira] Created: (CAMEL-2339) ScheduledPollConsumer.run swallows
Errors
ScheduledPollConsumer.run swallows Errors
-----------------------------------------
Key: CAMEL-2339
URL: https://issues.apache.org/activemq/browse/CAMEL-2339
Project: Apache Camel
Issue Type: Bug
Affects Versions: 2.0.0
Reporter: Jörn Kottmann
We have a camel route which uses the mail component
and polls from an IMAP mail server.
Through a deployment mistake the javax.activation.DataSource
class was not available and resulted in an
java.lang.NoClassDefFoundError Error which was swallowed
and not logged.
This resulted in a silent failure of the mail component.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2339) ScheduledPollConsumer.run swallows
Errors
Posted by "Jörn Kottmann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56802#action_56802 ]
Jörn Kottmann commented on CAMEL-2339:
--------------------------------------
In the current trunk version 893138 the Runnable ScheduledPollConsumer is executed by a ScheduledExecutorService. In the case that an Error is thrown from the run method the ScheduledExecutorService stops executing the run method and the ScheduledPollConsumer silently stops polling without any notification.
Errors can usually not be handled, but they should be at least be printed to the console and logged.
> ScheduledPollConsumer.run swallows Errors
> -----------------------------------------
>
> Key: CAMEL-2339
> URL: https://issues.apache.org/activemq/browse/CAMEL-2339
> Project: Apache Camel
> Issue Type: Bug
> Affects Versions: 2.0.0
> Reporter: Jörn Kottmann
>
> We have a camel route which uses the mail component
> and polls from an IMAP mail server.
> Through a deployment mistake the javax.activation.DataSource
> class was not available and resulted in an
> java.lang.NoClassDefFoundError Error which was swallowed
> and not logged.
> This resulted in a silent failure of the mail component.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2339) ScheduledPollConsumer.run swallows
Errors
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56803#action_56803 ]
Claus Ibsen commented on CAMEL-2339:
------------------------------------
There {{DefaultPollingConsumerPollStrategy}} will log at WARN with the ERROR in the {{rollback}} method.
{code}
public boolean rollback(Consumer consumer, Endpoint endpoint, int retryCounter, Exception e) throws Exception {
log.warn("Consumer " + consumer + " could not poll endpoint: " + endpoint.getEndpointUri() + " caused by: " + e.getMessage(), e);
// we do not want to retry
return false;
}
{code}
So you should be able to see this WARN log somewhere
> ScheduledPollConsumer.run swallows Errors
> -----------------------------------------
>
> Key: CAMEL-2339
> URL: https://issues.apache.org/activemq/browse/CAMEL-2339
> Project: Apache Camel
> Issue Type: Bug
> Affects Versions: 2.0.0
> Reporter: Jörn Kottmann
>
> We have a camel route which uses the mail component
> and polls from an IMAP mail server.
> Through a deployment mistake the javax.activation.DataSource
> class was not available and resulted in an
> java.lang.NoClassDefFoundError Error which was swallowed
> and not logged.
> This resulted in a silent failure of the mail component.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-2339) ScheduledPollConsumer.run swallows
Errors
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen updated CAMEL-2339:
-------------------------------
Component/s: camel-core
Priority: Minor (was: Major)
Fix Version/s: 2.2.0
Issue Type: Improvement (was: Bug)
> ScheduledPollConsumer.run swallows Errors
> -----------------------------------------
>
> Key: CAMEL-2339
> URL: https://issues.apache.org/activemq/browse/CAMEL-2339
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 2.0.0
> Reporter: Jörn Kottmann
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 2.2.0
>
>
> We have a camel route which uses the mail component
> and polls from an IMAP mail server.
> Through a deployment mistake the javax.activation.DataSource
> class was not available and resulted in an
> java.lang.NoClassDefFoundError Error which was swallowed
> and not logged.
> This resulted in a silent failure of the mail component.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CAMEL-2339) ScheduledPollConsumer.run swallows
Errors
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen reassigned CAMEL-2339:
----------------------------------
Assignee: Claus Ibsen
> ScheduledPollConsumer.run swallows Errors
> -----------------------------------------
>
> Key: CAMEL-2339
> URL: https://issues.apache.org/activemq/browse/CAMEL-2339
> Project: Apache Camel
> Issue Type: Bug
> Components: camel-core
> Affects Versions: 2.0.0
> Reporter: Jörn Kottmann
> Assignee: Claus Ibsen
> Fix For: 2.2.0
>
>
> We have a camel route which uses the mail component
> and polls from an IMAP mail server.
> Through a deployment mistake the javax.activation.DataSource
> class was not available and resulted in an
> java.lang.NoClassDefFoundError Error which was swallowed
> and not logged.
> This resulted in a silent failure of the mail component.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2339) ScheduledPollConsumer.run swallows
Errors
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56804#action_56804 ]
Claus Ibsen commented on CAMEL-2339:
------------------------------------
Ah its a java.lang.Error being thrown. Hmm those kind you should generally not try to handle and leave it to the JDK.
Its just the JDK that has a poor habit of not logging or somehow better report those FATAL errors.
> ScheduledPollConsumer.run swallows Errors
> -----------------------------------------
>
> Key: CAMEL-2339
> URL: https://issues.apache.org/activemq/browse/CAMEL-2339
> Project: Apache Camel
> Issue Type: Bug
> Affects Versions: 2.0.0
> Reporter: Jörn Kottmann
>
> We have a camel route which uses the mail component
> and polls from an IMAP mail server.
> Through a deployment mistake the javax.activation.DataSource
> class was not available and resulted in an
> java.lang.NoClassDefFoundError Error which was swallowed
> and not logged.
> This resulted in a silent failure of the mail component.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2339) ScheduledPollConsumer.run swallows
Errors
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56808#action_56808 ]
Claus Ibsen commented on CAMEL-2339:
------------------------------------
Yes I am fixing it now, running tests to ensure all is still okay.
> ScheduledPollConsumer.run swallows Errors
> -----------------------------------------
>
> Key: CAMEL-2339
> URL: https://issues.apache.org/activemq/browse/CAMEL-2339
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 2.0.0
> Reporter: Jörn Kottmann
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 2.2.0
>
>
> We have a camel route which uses the mail component
> and polls from an IMAP mail server.
> Through a deployment mistake the javax.activation.DataSource
> class was not available and resulted in an
> java.lang.NoClassDefFoundError Error which was swallowed
> and not logged.
> This resulted in a silent failure of the mail component.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2339) ScheduledPollConsumer.run swallows
Errors
Posted by "Jörn Kottmann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56807#action_56807 ]
Jörn Kottmann commented on CAMEL-2339:
--------------------------------------
Don't you think it would make sense to log and re-throw it ? Otherwise its difficult to find out whats going wrong.
> ScheduledPollConsumer.run swallows Errors
> -----------------------------------------
>
> Key: CAMEL-2339
> URL: https://issues.apache.org/activemq/browse/CAMEL-2339
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 2.0.0
> Reporter: Jörn Kottmann
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 2.2.0
>
>
> We have a camel route which uses the mail component
> and polls from an IMAP mail server.
> Through a deployment mistake the javax.activation.DataSource
> class was not available and resulted in an
> java.lang.NoClassDefFoundError Error which was swallowed
> and not logged.
> This resulted in a silent failure of the mail component.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CAMEL-2339) ScheduledPollConsumer.run swallows
Errors
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen resolved CAMEL-2339.
--------------------------------
Resolution: Fixed
trunk: 896858.
> ScheduledPollConsumer.run swallows Errors
> -----------------------------------------
>
> Key: CAMEL-2339
> URL: https://issues.apache.org/activemq/browse/CAMEL-2339
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Affects Versions: 2.0.0
> Reporter: Jörn Kottmann
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 2.2.0
>
>
> We have a camel route which uses the mail component
> and polls from an IMAP mail server.
> Through a deployment mistake the javax.activation.DataSource
> class was not available and resulted in an
> java.lang.NoClassDefFoundError Error which was swallowed
> and not logged.
> This resulted in a silent failure of the mail component.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.