You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/25 00:35:08 UTC

[GitHub] [airflow] wolfier commented on a change in pull request #14990: Fix url generation for TriggerDagRunOperatorLink

wolfier commented on a change in pull request #14990:
URL: https://github.com/apache/airflow/pull/14990#discussion_r600963085



##########
File path: airflow/utils/helpers.py
##########
@@ -213,4 +213,4 @@ def build_airflow_url_with_query(query: Dict[str, Any]) -> str:
     'http://0.0.0.0:8000/base/graph?dag_id=my-task&root=&execution_date=2020-10-27T10%3A59%3A25.615587
     """
     view = conf.get('webserver', 'dag_default_view').lower()
-    return f"/{view}?{parse.urlencode(query)}"
+    return url_for(f'Airflow.{view}', **query)

Review comment:
       Great insight! I will follow your suggestion! 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org