You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/10/21 06:00:42 UTC
[GitHub] [rocketmq] fantow opened a new issue #2369: [Consumer] There is a non-thread-safe operating when RocketMQ send expired message
fantow opened a new issue #2369:
URL: https://github.com/apache/rocketmq/issues/2369
**BUG REPORT**
1. Please describe the issue you observed:
**I think this is a non-thread-safe operationg.Because the collection is shared by multiThread,In this case,we use read-lock to make sure we get a thread-safe object reference,but we do not supply thread-safe for send operating.**
**If this is a issue,may I submit a PR to fix it?**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] lizhiboo commented on issue #2369: [Consumer] There is a non-thread-safe operating when RocketMQ send expired message
Posted by GitBox <gi...@apache.org>.
lizhiboo commented on issue #2369:
URL: https://github.com/apache/rocketmq/issues/2369#issuecomment-785059391
> **BUG REPORT**
>
> 1. Please describe the issue you observed:
> **I think this is a non-thread-safe operationg.Because the collection is shared by multiThread,In this case,we use read-lock to make sure we get a thread-safe object reference,but we do not supply thread-safe for send operating.**
>
> 
>
> **If this is a issue,may I submit a PR to fix it?**
Which collection is shared? If it only read by multi thread, i think it does matter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] shenhui0509 commented on issue #2369: [Consumer] There is a non-thread-safe operating when RocketMQ send expired message
Posted by GitBox <gi...@apache.org>.
shenhui0509 commented on issue #2369:
URL: https://github.com/apache/rocketmq/issues/2369#issuecomment-782582720
The `sendMessageBack` method is indeed thread-safe
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org