You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2019/10/06 19:15:48 UTC
[GitHub] [fineract] vorburger commented on a change in pull request #639:
Enhancement for FINERACT #516
vorburger commented on a change in pull request #639: Enhancement for FINERACT #516
URL: https://github.com/apache/fineract/pull/639#discussion_r331805503
##########
File path: fineract-provider/src/main/java/org/apache/fineract/useradministration/domain/AppUser.java
##########
@@ -230,7 +230,7 @@ public void updateRoles(final Set<Role> allRoles) {
final String passwordEncodedParamName = "passwordEncoded";
if (command.hasParameter(passwordParamName)) {
if (command.isChangeInPasswordParameterNamed(passwordParamName, this.password, platformPasswordEncoder, getId())) {
- final String passwordEncodedValue = command.passwordValueOfParameterNamed(passwordParamName, platformPasswordEncoder,
Review comment:
why remove this `final` ? It doesn't seem to do any harm, and prevents the variable from being changed again by mistake.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services