You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/09/24 05:08:11 UTC
[PR] Fix Pipeline runtime configuration conversion [shardingsphere]
terrymanu opened a new pull request, #39947:
URL: https://github.com/apache/shardingsphere/pull/39947
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Pipeline runtime configuration conversion [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #39947:
URL: https://github.com/apache/shardingsphere/pull/39947#issuecomment-5808063943
### Result
**Review Result: Mergeable**
The local candidate meets this task’s runtime configuration requirements. This conclusion covers code correctness only.
### Evidence
- Rule copies are generated from project rule configurations. The existing Sharding test confirms that changes to nested Properties affect neither the original rule nor the next copy.
- All 7 focused API tests and 2 Sharding tests passed. Spotless passed, and Checkstyle found no violations.
- `getCreationRuleConfigurations()` does not read the persisted parameter; actual data source values come from DataSourcePoolProperties.
### Coverage
- Standalone local candidate: one production file and one test file reviewed against the original working tree baseline.
- Root cause, callers, public contracts, regression tests, performance paths, and final diff were reviewed. No unresolved code-scope issues remain.
- CI was not reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Pipeline runtime configuration conversion [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #39947:
URL: https://github.com/apache/shardingsphere/pull/39947
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org