You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/05/01 21:21:40 UTC

[GitHub] [arrow-datafusion] alamb commented on pull request #6149: feat: LCM, GCD and Factorial

alamb commented on PR #6149:
URL: https://github.com/apache/arrow-datafusion/pull/6149#issuecomment-1530305491

   >  Hello, @alamb!
   > I noticed "Float64" problem, but I don't really understand how to solve it.
   > Do you have any idea what part of the code can cause this behavior?
   
   Hi @izveigor  -- I think what is happening is that the function's signature is (non obviously) being set to expect arguments via this fallback code:
   
   
   https://github.com/apache/arrow-datafusion/blob/6e8f91b41a6ec6a2680357b95b2489d87af33571/datafusion/expr/src/function.rs#L677-L686
   
   If you update `signature` to reflect the actual arguments desired (int64) I think the SQL will "just work"
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org